Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax highlighting #6517

Closed
wants to merge 2 commits into from
Closed

Fix syntax highlighting #6517

wants to merge 2 commits into from

Conversation

nelegalno
Copy link
Contributor

This is just a cosmetic fix for 2012_02_16_00_world_conditions.sql and 2012_02_20_02_world_conditons.sql.

@DDuarte
Copy link
Contributor

DDuarte commented May 14, 2012

Should have changed from # to -- instead.

@nelegalno
Copy link
Contributor Author

I tried but still got error messages so decided to leave it at that.

P.S. I'm using the Combine SQL Updates script so the errors could be caused by it as well.

@Xanvial
Copy link
Contributor

Xanvial commented May 14, 2012

there should be a space after --, maybe you haven't put it

@Warpten
Copy link
Contributor

Warpten commented May 14, 2012

"#" becomes "-- "

@nelegalno
Copy link
Contributor Author

After replacing all the # with -- (there are spaces after them) I get thous errors:

Query: -- Below is a procedure to dynamically convert custom content to conditions table. -- However this procedure only works for MySQ...

Error Code: 1064
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/*
DROP PROCEDURE IF EXISTS ConvertSpellClickConditions;
DELIMITER //' at line 6

---------------------------------------------------

Query: CREATE PROCEDURE ConvertSpellClickConditions() BEGIN DECLARE counter INT DEFAULT 0; DECLARE recordCount INT DEFAULT 0; DECLARE c...

Error Code: 1064
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '//
DELIMITER' at line 83

---------------------------------------------------

Query: CALL ConvertSpellClickConditions(); DROP PROCEDURE ConvertSpellClickConditions; */ ALTER TABLE `npc_spellclick_spells` DROP COLU...

Error Code: 1064
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'DROP PROCEDURE ConvertSpellClickConditions;
*/
ALTER TABLE `npc_spellclick_spell' at line 2

@Warpten
Copy link
Contributor

Warpten commented May 14, 2012

Because SQLYog doesnt understand commented out procedure declarations.

@nelegalno
Copy link
Contributor Author

@Warpten can you suggest something similar for windows that will work (Is HeidiSQL better)?

@Xanvial
Copy link
Contributor

Xanvial commented May 14, 2012

personally i use HeidiSQL, haven't encounter any problem

@Star-lion
Copy link
Contributor

i use mysql workbench o.o

@nelegalno
Copy link
Contributor Author

10x I'll try them. Hope they have portable versions ...

@DDuarte
Copy link
Contributor

DDuarte commented May 14, 2012

  1. Open command line
  2. Type mysql -uUSER -pPASS world < AllWorldUpdates.sql
  3. ...
  4. Profit

;)

@Warpten
Copy link
Contributor

Warpten commented May 14, 2012

there's a space between the -u and the actual user name as far as i remember (only using the cli trough putty, ive wamp here, lazy enough to add mysql to my path env var)

@DDuarte DDuarte closed this in fc0950d May 19, 2012
DDuarte pushed a commit that referenced this pull request May 19, 2012
DDuarte added a commit to raczman/TrinityCore that referenced this pull request Apr 20, 2014
(Core/Opcs: Use Handle_NULL for an unused opcode)

Closes TrinityCore#6517 (pr)
DDuarte pushed a commit to raczman/TrinityCore that referenced this pull request Apr 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants