Fix receiving whispers while being dnd #8428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use the same variable to store the message for AFK and DND
ghost
assigned 
| @@ -19963,42 +19957,29 @@ void Player::Whisper(const std::string& text, uint32 language, uint64 receiver) | |||
| std::string _text(text); | |||
| sScriptMgr->OnPlayerChat(this, CHAT_MSG_WHISPER, language, _text, rPlayer); | |||
|
|
|||
| // when player you are whispering to is dnd, he cannot receive your message, unless you are in gm mode | |||
| if (!rPlayer->isDND() || isGameMaster()) | |||
There was a problem hiding this comment.
This breaks the ability to send whispers as a GM to a DND player.
There was a problem hiding this comment.
on retail a DND player should always receive whispers no matter if the whisperer is a GM or not. And this is what the patch does. It removes the strange restriction to block whispers while being DND. The check you are talking about previously excluded GMs from those blocked whispers but that is obsolete now.
EDIT: Here is the discussion of this patch btw (need to login with old acc): http://getmangos.com/community/viewtopic.php?id=15375
|
How come I didn't see this PR up until now? o.O |
Closed
DDuarte
added a commit
to raczman/TrinityCore
that referenced
this pull request
Apr 20, 2014
Closes TrinityCore#8428 Also update some sql file names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been the blizzlike behavior since at least TBC.
On retail if users do not even want to see /dnd messages they have to use addons
IMPORTANT:
core string
(707,'%s wishes to not be disturbed and cannot receive whisper messages: %s',needs to be changed to(707,'%s does not wish to be disturbed: %s',