Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #61 and #51, along with enhancements and fixes #68

Merged
merged 3 commits into from
May 13, 2024
Merged

Fixes #61 and #51, along with enhancements and fixes #68

merged 3 commits into from
May 13, 2024

Conversation

ASHISH-JHA94
Copy link
Contributor

@ASHISH-JHA94 ASHISH-JHA94 commented May 13, 2024

This Pull Request aims to resolve issues #61 and #51 while also introducing several enhancements to elevate the project's functionality, user experience, and maintainability. Below is a breakdown of the changes made:

Addressed Issues:

#61 issue
#51: issue
Enhancements:

1. File Structure Organization:

Reorganized the file structure to improve code organization and maintainability.

2.Home Page Addition:

Added a home.html page as the project's landing page to provide users with a starting point and essential information about the project.

3 **Temporary Navbar and Footer:**

Introduced navbar and footer, which can be styled in future iterations to enhance the project's visual appeal and navigation.

4.**Redirecting Issue Resolution:**

Resolved the redirection issue causing after login.

5**Token Storage in Local Storage:**

Implemented functionality to save the authentication token in the browser's local storage after successful login. This enhancement ensures seamless authentication for subsequent user interactions.

6. **Username to Email Fix:**

Updated the authentication system to use email instead of username for user identification, aligning with modern authentication standards and improving user experience.

7**Testing and Quality Assurance:**

Conducted thorough testing to ensure all changes function correctly across various browsers and devices.
Verified that the application's features behave as expected, including navigation, authentication, and token storage.
Followed best practices to maintain code quality, including documentation and adherence to coding standards.

**8.solve merge conflict**

Additional Notes:

This Pull Request represents a significant improvement to the project, addressing critical issues and introducing new features and enhancements.
Feedback and suggestions for further improvements are welcome and appreciated.
Related Issues:

#61
#51
Checklist:

All tests pass successfully.

  • Code follows the project's coding style and conventions.
  • Reviewers are assigned to provide feedback.

Reviewer Checklist:

  • Reviewed the code changes and provided constructive feedback.
  • Tested the changes locally to verify their functionality.
  • Approved the PR after ensuring that it meets the project's standards and requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants