-
Notifications
You must be signed in to change notification settings - Fork 5
FxAsync no error handling -> future never finishes #23
Comments
Oh indeed. Nice catch! Although it stems from me misusing CompletableFuture to begin with. Will fix asap 👍 |
Fixed with 9e6c8b2 |
Yes and it might not be a perfect implementation as if user does not use async (thenAcceptAsync, etc) methods on the returned completableFuture then it will be the FX thread that will run (might make UI stuck if long running task after). |
Sorry what do you mean I don't really follow 😅 Or is the case that using for example |
Yes it will keep blocking the FX thread as it is the one used as the executor. All non-async methods will be executed on FX thread Maybe this should be clearly stated in the javadoc of your methods otherwise fx thread may be stuck on those sync methods.
|
Well that's interesting. Thank you very much for the info and I'll definitely add this to the documentation! |
Thank you again for the info (the more you know... apparently I'm not the only one who got shaded by Added documentation warnings in b5ca10a 👍 |
change to:
The text was updated successfully, but these errors were encountered: