Skip to content

Commit

Permalink
openjdk[78]: Add a \todo comment about the cups dependency.
Browse files Browse the repository at this point in the history
Having a language install a printing system violates the Principle of
Least Astonishment.  Add a comment to be replaced with an explanation
of why this is necessary or helpful.
  • Loading branch information
gdt committed Jul 7, 2018
1 parent 11f6b30 commit b4742ac
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion lang/openjdk7/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# $NetBSD: Makefile,v 1.124 2018/04/17 22:29:40 wiz Exp $
# $NetBSD: Makefile,v 1.125 2018/07/07 11:48:18 gdt Exp $

JDK_MICRO= 141
DISTNAME= openjdk-1.7.${JDK_MICRO}-20170813
Expand Down Expand Up @@ -295,6 +295,9 @@ MAKE_ENV+= STRIP=${PREFIX}/bin/gstrip
.include "../../devel/zlib/buildlink3.mk"
.include "../../fonts/fontconfig/buildlink3.mk"
.include "../../graphics/freetype2/buildlink3.mk"
# \todo Explain why cups needs to be included, because having the
# package installed is unexpected for those who have not chosen to use
# cups.
BUILDLINK_DEPMETHOD.cups-base?= build
.include "../../print/cups-base/buildlink3.mk"
.include "../../mk/java-env.mk"
Expand Down
5 changes: 4 additions & 1 deletion lang/openjdk8/Makefile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# $NetBSD: Makefile,v 1.65 2018/05/26 21:26:46 ryoon Exp $
# $NetBSD: Makefile,v 1.66 2018/07/07 11:48:18 gdt Exp $

DISTNAME= openjdk-1.8.172-20180527
PKGNAME= openjdk8-1.8.172
Expand Down Expand Up @@ -270,6 +270,9 @@ MAKE_ENV+= STRIP=${PREFIX}/bin/gstrip
.include "../../devel/zlib/buildlink3.mk"
.include "../../fonts/fontconfig/buildlink3.mk"
.include "../../graphics/freetype2/buildlink3.mk"
# \todo Explain why cups needs to be included, because having the
# package installed is unexpected for those who have not chosen to use
# cups.
BUILDLINK_DEPMETHOD.cups-base?= build
.include "../../print/cups-base/buildlink3.mk"
.include "../../mk/java-env.mk"
Expand Down

0 comments on commit b4742ac

Please sign in to comment.