Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add About page, fix UNSAFE_componentWillMount error #19

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Add About page, fix UNSAFE_componentWillMount error #19

merged 3 commits into from
Sep 4, 2023

Conversation

wllmwu
Copy link
Member

@wllmwu wllmwu commented Sep 2, 2023 •
edited
Loading

Changes

What changes did you make? Include screenshots if applicable, or explain how to view the changes.

  • Add About page (path /about) to demonstrate client-side routing
  • Replace react-helmet with react-helmet-async to fix error on page load
  • Reword some minor things

Home page:
Screenshot 2023-09-02 at 10 01 50

About page:
Screenshot 2023-09-02 at 10 02 13

Testing

How did you confirm your changes work? (Automated tests, manual verification, etc.)

  • Tests pass
  • Manually verified that the error is gone
  • Manually verified that navigating between pages works (by clicking links and by directly inputting URL in browser)

Tracking

Add your issue number below.

@wllmwu wllmwu added the frontend label Sep 2, 2023
navidboloorian
navidboloorian approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@navidboloorian navidboloorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job figuring out what was causing the error

@navidboloorian navidboloorian merged commit 3acfda0 into main Sep 4, 2023
2 checks passed
@navidboloorian navidboloorian deleted the finish-frontend branch September 4, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidboloorian navidboloorian navidboloorian approved these changes

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add About page Fix UNSAFE_componentWillMount error
2 participants
@wllmwu @navidboloorian