Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect padding row derivation in memory tables #37

Closed
jan-ferdinand opened this issue Aug 19, 2022 · 0 comments
Closed

Incorrect padding row derivation in memory tables #37

jan-ferdinand opened this issue Aug 19, 2022 · 0 comments
Labels
🪳 bug Something is not working 🤖 code Changes the implementation 💫 good first issue Good for newcomers 🟡 prio: medium Not super urgent

Comments

@jan-ferdinand
Copy link
Member

jan-ferdinand commented Aug 19, 2022

Currently, all memory tables (i.e., RAM, OpStack, JumpStack) derive their next padding row directly from their current last row, incrementing the value of column cycle count clk by 1. However, since a memory table gets sorted by memory pointer (ramp, osp, jsp, respectively) first, clk second, this derivation of the padding row is generally incorrect: the highest value of clk and the highest value of the memory pointer do not have to appear in the same row.

The solution that I think is easiest to implement:
Derive the memory tables from the processor table after the processor table has been padded.

@jan-ferdinand jan-ferdinand added 🪳 bug Something is not working 💫 good first issue Good for newcomers 🟡 prio: medium Not super urgent 🤖 code Changes the implementation labels Aug 19, 2022
jan-ferdinand added a commit that referenced this issue Aug 19, 2022
This makes sense in anticipation of #10. Relates to #37.
jan-ferdinand added a commit that referenced this issue Aug 31, 2022
jan-ferdinand added a commit that referenced this issue Aug 31, 2022
- VM outputs an AET, not BaseMatrices
- sorting is done on matrix derivation (#37)
- fix minor bug regarding OSP / OSV's indices

Co-authored-by: Alan <alan@neptune.cash>
jan-ferdinand added a commit that referenced this issue Aug 31, 2022
Relates to #37

Co-authored-by: Alan <alan@neptune.cash>
jan-ferdinand added a commit that referenced this issue Sep 1, 2022
Co-authored-by: Alan <alan@neptune.cash>
jan-ferdinand added a commit that referenced this issue Sep 1, 2022
jan-ferdinand added a commit that referenced this issue Sep 1, 2022
- VM outputs an AET, not BaseMatrices
- sorting is done on matrix derivation (#37)
- fix minor bug regarding OSP / OSV's indices

Co-authored-by: Alan <alan@neptune.cash>
jan-ferdinand added a commit that referenced this issue Sep 1, 2022
Relates to #37

Co-authored-by: Alan <alan@neptune.cash>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something is not working 🤖 code Changes the implementation 💫 good first issue Good for newcomers 🟡 prio: medium Not super urgent
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant