Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad all tables to the same height #10

Closed
jan-ferdinand opened this issue Aug 8, 2022 · 0 comments
Closed

Pad all tables to the same height #10

jan-ferdinand opened this issue Aug 8, 2022 · 0 comments
Assignees
@sshine
Labels
🤖 code Changes the implementation ✨ enhancement Improvement or new feature 🔴 prio: high Pretty urgent

Comments

@jan-ferdinand
Copy link
Member

A Verifier needs to compute (what we call) unit_distances from the extension tables' padded_heights. For that, they currently need to have access to the padded height of all tables, which (for now) is communicated via the proof stream.

At a runtime cost for general proving, moving to a single padded_height simplifies the Verifier. A simpler Verifier implies a faster runtime for the recursive Verifier. Thus, the proposed change should be implemented.

(Originally issue number 31 in the internal issue tracker.)
@jan-ferdinand jan-ferdinand added ✨ enhancement Improvement or new feature 🟡 prio: medium Not super urgent 🤖 code Changes the implementation labels Aug 8, 2022
@jan-ferdinand jan-ferdinand self-assigned this Aug 8, 2022
@jan-ferdinand jan-ferdinand mentioned this issue Aug 8, 2022
Closed
jan-ferdinand added a commit that referenced this issue Aug 19, 2022
@jan-ferdinand
Derive padding rows even for empty tables
a1f38c3 
This makes sense in anticipation of #10. Relates to #37.
@jan-ferdinand jan-ferdinand mentioned this issue Sep 7, 2022
Closed
@jan-ferdinand jan-ferdinand added 🔴 prio: high Pretty urgent and removed 🟡 prio: medium Not super urgent labels Sep 19, 2022
jan-ferdinand added a commit that referenced this issue Sep 20, 2022
@jan-ferdinand
Pad all tables to the same height
338efcf 
Fix #10
@jan-ferdinand jan-ferdinand mentioned this issue Sep 20, 2022
Closed
jan-ferdinand added a commit that referenced this issue Sep 20, 2022
@jan-ferdinand
Update specification with new padding behavior (#10)
c539ca1 
Also some padding behavior that has been implemented a while ago but was
never properly documented.

Also fix the specification with respect to the U32 Table checking
whether the operands actually fit in 32 bits, which has been implemented
long ago.
jan-ferdinand added a commit that referenced this issue Sep 20, 2022
@jan-ferdinand
Remove obsolete method for computing unit_distance (#10)
cd1c8e9
jan-ferdinand added a commit that referenced this issue Sep 21, 2022
@jan-ferdinand
Update specification with new padding behavior (#10)
f1843e0 
Also some padding behavior that has been implemented a while ago but was
never properly documented.

Also fix the specification with respect to the U32 Table checking
whether the operands actually fit in 32 bits, which has been implemented
long ago.
jan-ferdinand added a commit that referenced this issue Sep 22, 2022
@jan-ferdinand
Add test for same padded height (#10)
563d6d9
jan-ferdinand added a commit that referenced this issue Sep 29, 2022
@jan-ferdinand
Add test for same padded height (#10)
8b0ddfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sshine sshine

Labels
🤖 code Changes the implementation ✨ enhancement Improvement or new feature 🔴 prio: high Pretty urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pad all tables to the same height TritonVM/triton-vm
2 participants
@sshine @jan-ferdinand