Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pad all tables to the same height #66

Closed
wants to merge 4 commits into from
Closed

Pad all tables to the same height #66

wants to merge 4 commits into from

Conversation

jan-ferdinand
Copy link
Member

Fix #10

@jan-ferdinand
Update specification with new padding behavior (#10)
c539ca1 
Also some padding behavior that has been implemented a while ago but was
never properly documented.

Also fix the specification with respect to the U32 Table checking
whether the operands actually fit in 32 bits, which has been implemented
long ago.
@jan-ferdinand
Remove obsolete method for computing unit_distance (#10)
cd1c8e9
sshine
sshine approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@sshine sshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only had comments about formatting code, so I discarded those for now.

@jan-ferdinand jan-ferdinand deleted the one-pad-to-rule-them-all branch September 21, 2022 12:14
@jan-ferdinand
Copy link
Member Author

Rebased, squashed, and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszepieniec aszepieniec aszepieniec left review comments

@sshine sshine sshine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pad all tables to the same height
3 participants
@jan-ferdinand @sshine @aszepieniec