-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Output Trigger Regex seems incorrect #11
Comments
Oddly enough, reviewing my message has given me an indication; The "[*([]" block appears to be used to hide text, presumably to hide the SD prompts from the user. Will close this issue; the regex is likely fine, and the lack of hidden SD prompts coming through is a separate issue. |
The Regex-wise, it just a simple It makes sense to remove this block (or make it optional) and append the |
- Add support for FaceID feature of SD.Next - Add support for IP Adapters feature of SD.Next - Add hires.fix related params - Update default generation params to what RealisiticVision v6.B recommends - Rename "enhace_face" related params to "restore_face" - Fix some params not updating via UI, especially params set to default value and params of type boolean or enum - Fix UI wrongly setting password as endpoint - Fix UI wrongly setting username as endpoint - Fix some AUTOMATIC1111 related API incompatibilities - Fix trigger on output message, fixes #11 - Fix multithreading issues related to context, fixes #13 - Fix full_quality param not set for SD.Next - Fix missing trace log when errors are logged
Description
The default stable_diffusion-interactive_mode_output_trigger_regex within settings.debug.yaml (currently " .[(\b.+?\b(image|pic(ture)?|photo|snap(shot)?|selfie|meme)(s?)") seems to have an issue: The "[*([]" block appears to be searching for those characters directly, which are unlikely to appear in most output most strings, causing image output to almost always be prevented.
Caveats
I'm not familiar enough with regex to tell exactly what that block is trying to accomplish. However, I can confirm that it is the cause of the match failing; see images below.
Before:
![image](https://private-user-images.githubusercontent.com/64934262/293829861-8aa08c94-cb44-47bc-a334-fac22ddfded5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIzMzQwMjYsIm5iZiI6MTcyMjMzMzcyNiwicGF0aCI6Ii82NDkzNDI2Mi8yOTM4Mjk4NjEtOGFhMDhjOTQtY2I0NC00N2JjLWEzMzQtZmFjMjJkZGZkZWQ1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMwVDEwMDIwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThlZTZjZmQ3NjBhNTRiM2Q4MjZmZThhNWMwNWQ3YjdkN2Y2NTQ4NWY3NTAxNGVlMDMxNGVmYzQwMGJiZjYwMGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.L0d91ZK6iOw3sIrcbjSTXnorfYwRCOWsaBtdnJClfDI)
After manually changing pattern to remove block:
![image](https://private-user-images.githubusercontent.com/64934262/293830037-fe32d568-9e2c-4ebf-abb3-fabc1cdd4b81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIzMzQwMjYsIm5iZiI6MTcyMjMzMzcyNiwicGF0aCI6Ii82NDkzNDI2Mi8yOTM4MzAwMzctZmUzMmQ1NjgtOWUyYy00ZWJmLWFiYjMtZmFiYzFjZGQ0YjgxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzMwVDEwMDIwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ2Njc4MWE4NzFmY2M2OTE5NjE0YjVhZTFhNTA1MWY2OTU4YmRmMGIyZjRjNTg5ZGQ4Y2E0MzgyNGMzZDJkMDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vna6qzN_A_YKQ35fkgjxZ9cfKaNimOhDymnf8Q2Ray4)
As this is a default, it is already easily changed, but modifying the default directly would likely help prevent confusion
Additional Suggestions
Adding "draws|paints|creates" to the first group here would help increase the chances of image production when it would make sense to occur.
Why not just make a PR?
I want to confirm what the intended behavior of that block is before I go about pulling it out.
The text was updated successfully, but these errors were encountered: