Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Lost context in Continous mode #13

Closed
TheInvisibleMage opened this issue Jan 3, 2024 · 1 comment
Closed

Issue: Lost context in Continous mode #13

TheInvisibleMage opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TheInvisibleMage
Copy link

TheInvisibleMage commented Jan 3, 2024

Description

Continuous mode seems non-functional about half of the time; no image is produced.
Debugging shows that the context seems to "lag behind" sometimes. An example debug sequence is below.

  • First input sent. Context at line 54 of script.py is None. By line 158 of script.py, context is still none. Since we are not in interactive mode, the following check fails, so no image is ever generated.
  • Second input sent. Context at line 54 of script.py shows information relating to the first input instead. By line 158 of script.py, context is None again.

It should be noted that the above is not consistent; sometimes the desired context makes it through, and the image generates successfully. This would suggest some kind of race condition around the context being set/loaded.

UI after one failure, during second attempt:
image

Debug during second attempt:
image

Additional Info

  • Branch: main
  • Commit: d4667f8
  • Model used: TheBloke_NeuralHermes-2.5-Mistral-7B-GGUF
@Trojaner
Copy link
Owner

Trojaner commented Jan 3, 2024

I noticed this issue as well but did not find a good way to reproduce it in a reliable way. Probably related to a different thread handling that part. I already reworked the way how the context is stored and it will no longer use a local thread state (as text-generation-webui doesn't support multithreading anyway). Might rework it further and make it part of state instead but for now it seems to be working.

I will push the related changes later this weekend as part of a bigger update that also fixes some other stuff like some values (especially booleans and enums) not being updated correctly via the UI.

@Trojaner Trojaner added the bug Something isn't working label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants