Skip to content

Commit

Permalink
doc: remove "note that" from CPP_STYLE_GUIDE.md
Browse files Browse the repository at this point in the history
Refs: nodejs/remark-preset-lint-node#16

PR-URL: nodejs#28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Trott committed Jun 23, 2019
1 parent dc5eb64 commit 6f15029
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CPP_STYLE_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ When there is a need to throw errors from a C++ binding method, try to
return the data necessary for constructing the errors to JavaScript,
then construct and throw the errors [using `lib/internal/errors.js`][errors].

Note that in general, type-checks on arguments should be done in JavaScript
In general, type-checks on arguments should be done in JavaScript
before the arguments are passed into C++. Then in the C++ binding, simply using
`CHECK` assertions to guard against invalid arguments should be enough.

Expand Down

0 comments on commit 6f15029

Please sign in to comment.