Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tokio rt dependency #9

Merged
merged 2 commits into from
Mar 9, 2023
Merged

chore: remove tokio rt dependency #9

merged 2 commits into from
Mar 9, 2023

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Mar 9, 2023

As pointed out in TrueLayer/reqwest-middleware#79, we have a dependency on tokio. It's not necessary as it just provides task_locals. We can imitate that using thread locals

@conradludgate conradludgate requested a review from a team as a code owner March 9, 2023 08:40
@@ -1,12 +1,15 @@
[package]
name = "task-local-extensions"
version = "0.1.4-alpha0"
authors = ["Helge Hoff <helge.hoff@truelayer.com>"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@conradludgate conradludgate merged commit 9a7d3c3 into main Mar 9, 2023
@conradludgate conradludgate deleted the no-more-tokio branch March 9, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants