[WIP]Add NULS address and transaction signature C++ impl #193

daviyang35 · 2019-03-20T09:49:12Z

Description

First PR.

Add NULS address and transaction signature C++ impl

Testing instructions

Types of changes

New feature (non-breaking change which adds functionality)

Add NULS Address and Signer.
Add NULS Address/Signer unittest.
Add NULS Address/Signer C Interface.

Checklist

Prefix PR title with [WIP] if necessary.
Add tests to cover changes as needed.
Update documentation as needed.

encode64LE(val & 0xffffffffffff, data) will write 8 byte data to buffer.
So we use encode48LE to write 6 byte number.

src/proto/NULS.proto

fix remark field data type

daviyang35 · 2019-03-20T11:09:02Z

already fix spell and field data type error

alejandro-isaza

Please fill in the checklist:

src/NULS/Address.cpp

src/NULS/Signer.cpp

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

daviyang35 · 2019-03-21T03:10:04Z

Address derivation test. Put this test in the CoinTests.cpp file

src/NULS/Address.cpp

hewigovens · 2019-03-21T07:36:15Z

src/interface/TWNULSSigner.cpp

+
+#include <sys/time.h>
+
+int64_t getCurrentTime()


I think we can remove this, and add a timestamp field to TransactionInput

hewigovens · 2019-03-21T07:37:01Z

src/proto/NULS.proto

+package TW.NULS.Proto;
+option java_package = "wallet.core.jni.proto";
+
+message TransactionInput {


could you please change this to SigningInput? like other chains

hewigovens · 2019-03-21T07:40:35Z

src/NULS/Signer.cpp

+    else if (tx.outputs_size()==0) {
+        throw std::invalid_argument("There must be at least one output, something is missed");
+    }
+    auto priv = Address::importHexPrivateKey(tx.private_key());


I don't think we need importHexPrivateKey, you can add a private_key to SigningInput and get it from signer

There are 3 possibilities for the private key exported by nuls wallet. If the import is used directly, it will fail because the length does not meet the requirements.

let's just consider the simplest case that we derive a private key from mnemonic, @vikmeup what do you think?

hewigovens · 2019-03-21T07:42:19Z

src/NULS/Signer.h

+     * @param remarkSize  UTF-8 encode remark string length. Empty is 0
+     * @return needed fee
+     */
+    static uint64_t getFee(uint32_t inputCount, uint32_t outputCount, uint32_t remarkSize);


could you please check and use TransactionPlan and UnspentCalculator? We had same problems when calculating fees for bitcoin and zcash

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

daviyang35 · 2019-04-05T09:23:45Z

@hewigovens I add TransactionBuilder help you make transaction.

# Conflicts: # JNI/cpp/HDWallet.c # JNI/cpp/HDWallet.h # JNI/cpp/PublicKey.c # JNI/cpp/PublicKey.h # JNI/cpp/StellarAddress.c # JNI/cpp/StellarAddress.h # JNI/java/wallet/core/jni/CoinType.java # JNI/java/wallet/core/jni/HDWallet.java # JNI/java/wallet/core/jni/PublicKey.java # JNI/java/wallet/core/jni/StellarAddress.java # JNI/java/wallet/core/jni/proto/Binance.java # TrustWalletCore.podspec # android/gradle.properties # include/TrustWalletCore/TWHDWallet.h # src/Base58.h # src/Bitcoin/Address.cpp # src/Bitcoin/Address.h # src/Bitcoin/Script.cpp # src/Coin.cpp # src/Coin.h # src/Data.h # src/Decred/Address.cpp # src/Ethereum/Address.cpp # src/HDWallet.cpp # src/HDWallet.h # src/Hash.h # src/Keystore/Account.cpp # src/NEO/Address.h # src/Tezos/Address.cpp # src/Tezos/Address.h # src/Tezos/Forging.cpp # src/Theta/Transaction.h # src/Tron/Address.h # src/Zcash/TAddress.cpp # src/Zcash/TAddress.h # src/interface/TWCoinTypeConfiguration.cpp # src/interface/TWPrivateKey.cpp # src/interface/TWStellarAddress.cpp # swift/Sources/Addresses/WanchainAddressExtension.swift # swift/Sources/Binance.pb.swift # swift/Sources/Blockchains/Tron.swift # swift/Sources/CoinType.swift # swift/Sources/HDWallet.swift # swift/Sources/PublicKey.swift # swift/Sources/StellarAddress.swift # swift/Tests/CoinAddressDerivationTests.swift # tests/CoinTests.cpp # tests/interface/TWCoinTypeConfigTests.cpp # tests/interface/TWHDWalletTests.cpp # tests/interface/TWRippleTests.cpp # tests/interface/TWZcashTests.cpp # tools/lint

vikmeup · 2019-04-05T17:55:19Z

@daviyang35 can you rebase against master and remove generated files? we don't commit those anymore

* Generate Address conformance in Swift * Delete manual conformances to Address

daviyang35 · 2019-04-07T05:10:24Z

@vikmeup I'm clean some generate file already.

codecov · 2019-04-07T05:16:33Z

Codecov Report

Merging #193 into master will increase coverage by 0.42%.
The diff coverage is 89.18%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage    79.3%   79.72%   +0.42%     
==========================================
  Files         184      188       +4     
  Lines        4435     4621     +186     
==========================================
+ Hits         3517     3684     +167     
- Misses        918      937      +19

Impacted Files	Coverage Δ
src/interface/TWCoinTypeConfiguration.cpp	`77.22% <0%> (-1.76%)`	⬇️
src/NULS/Signer.h	`100% <100%> (ø)`
src/Coin.cpp	`73% <100%> (+0.55%)`	⬆️
src/NULS/Address.cpp	`84.9% <84.9%> (ø)`
src/NULS/TransactionBuilder.h	`92.72% <92.72%> (ø)`
src/NULS/Signer.cpp	`94.28% <94.28%> (ø)`
src/Base58.h	`100% <0%> (ø)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b876b...1fff601. Read the comment docs.

hewigovens · 2019-04-08T00:30:33Z

@daviyang35 hi, could you please fix the Android CI?

daviyang35 · 2019-04-09T14:54:32Z

@hewigovens Process done.

hewigovens

@daviyang35 I strongly recommend you to branch out from latest master and submit a new pr you don't know how to rebase, too many unrelated changes:

include/TrustWalletCore/DecredSigner.c
include/TrustWalletCore/DecredSigner.h
include/TrustWalletCore/OntologySigner.c
...
swift/Sources/CoinType.swift
...

daviyang35 added 7 commits March 20, 2019 00:44

Add NULS address and transaction signature C++ impl

8311831

process indent

98d2d7a

remove serializerRemark

dbc2ec5

process Coin.cpp format

19e8d10

process indent

cdbefab

process Coin.cpp format

510e204

process Coin.cpp format

53a74ee

vikmeup reviewed Mar 20, 2019

View reviewed changes

src/proto/NULS.proto Outdated Show resolved Hide resolved

src/proto/NULS.proto Outdated Show resolved Hide resolved

daviyang35 added 3 commits March 20, 2019 18:50

rename as private_key

e7067b0

fix remark field data type

Merge branch 'master' into master

1d197ea

fix merge error

fd56092

alejandro-isaza reviewed Mar 20, 2019

View reviewed changes

src/NULS/Address.cpp Outdated Show resolved Hide resolved

src/NULS/Address.cpp Outdated Show resolved Hide resolved

src/NULS/Address.cpp Outdated Show resolved Hide resolved

src/NULS/Address.cpp Outdated Show resolved Hide resolved

src/NULS/Signer.cpp Outdated Show resolved Hide resolved

alejandro-isaza and others added 5 commits March 21, 2019 10:18

Update src/NULS/Address.cpp

ea250ea

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

Update src/NULS/Address.cpp

5d42188

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

Update src/NULS/Address.cpp

30612cc

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

Update src/NULS/Signer.cpp

7b8550c

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

use TW::Base58

b5ffac2

daviyang35 added 2 commits March 21, 2019 11:11

Implement coin configuration src/include/TWCoinTypeConfiguration.cpp

420f793

Address derivation test. Put this test in the CoinTests.cpp file

Merge branch 'master' into master

63fccdf

hewigovens reviewed Mar 21, 2019

View reviewed changes

src/NULS/Address.cpp Show resolved Hide resolved

hewigovens reviewed Mar 21, 2019

View reviewed changes

src/NULS/Address.cpp Outdated Show resolved Hide resolved

hewigovens reviewed Mar 21, 2019

View reviewed changes

daviyang35 and others added 3 commits March 21, 2019 16:11

NULS main net id as static const

666ce9d

Update src/NULS/Address.cpp

7662a19

Co-Authored-By: daviyang35 <daviyang35@gmail.com>

Import multiple coins instead of one at a time (#202)

6ef5d54

alejandro-isaza and others added 7 commits March 31, 2019 21:35

Fix lint script

cf47c31

Fix Stellar address

f010233

Fix CashAddress

00a7f79

Fix Ontology code generation

e317b55

Catch Tron address construction exceptions

fe33a2d

Synchronize api change

4bec71c

add NULS TransactionBuilder

12fb226

daviyang35 added 2 commits April 5, 2019 22:16

fix merge error

cabe727

alejandro-isaza and others added 7 commits April 7, 2019 12:51

Add code coverage reporting (#267)

2b0f00a

Add support for Cosmos SDK - transaction signing (#244)

1041a07

Generate Swift typealiases for Protobuf types (#268)

ca93797

Add codecov and cosmos icon

4995014

Generate Address conformances for Swift (#269)

08b8309

* Generate Address conformance in Swift * Delete manual conformances to Address

Fix Swift 5 and some C++ warnings (#270)

3ad05c7

remove generate files

b3c53df

daviyang35 added 3 commits April 7, 2019 23:02

using clang-format

e325ae0

using clang-format

5c87a7f

clean code

ab64820

daviyang35 added 2 commits April 9, 2019 22:22

remove unused files

26621ed

Merge branch 'master' into master

1fff601

hewigovens suggested changes Apr 10, 2019

View reviewed changes

daviyang35 closed this Apr 10, 2019

eddywm mentioned this pull request Apr 20, 2019

A NULL pointer crash on startup. Likely a regression on HDWallet.GetExtendedKey #345

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP]Add NULS address and transaction signature C++ impl #193

[WIP]Add NULS address and transaction signature C++ impl #193

daviyang35 commented Mar 20, 2019

daviyang35 commented Mar 20, 2019

alejandro-isaza left a comment

daviyang35 commented Mar 21, 2019

hewigovens Mar 21, 2019

hewigovens Mar 21, 2019

hewigovens Mar 21, 2019

daviyang35 Mar 21, 2019

hewigovens Mar 21, 2019

hewigovens Mar 21, 2019

daviyang35 commented Apr 5, 2019

vikmeup commented Apr 5, 2019

daviyang35 commented Apr 7, 2019

codecov bot commented Apr 7, 2019 •

edited

Loading

hewigovens commented Apr 8, 2019

daviyang35 commented Apr 9, 2019

hewigovens left a comment •

edited

Loading


		#include <sys/time.h>

		int64_t getCurrentTime()

[WIP]Add NULS address and transaction signature C++ impl #193

[WIP]Add NULS address and transaction signature C++ impl #193

Conversation

daviyang35 commented Mar 20, 2019

Description

Testing instructions

Types of changes

Checklist

daviyang35 commented Mar 20, 2019

alejandro-isaza left a comment

Choose a reason for hiding this comment

daviyang35 commented Mar 21, 2019

hewigovens Mar 21, 2019

Choose a reason for hiding this comment

hewigovens Mar 21, 2019

Choose a reason for hiding this comment

hewigovens Mar 21, 2019

Choose a reason for hiding this comment

daviyang35 Mar 21, 2019

Choose a reason for hiding this comment

hewigovens Mar 21, 2019

Choose a reason for hiding this comment

hewigovens Mar 21, 2019

Choose a reason for hiding this comment

daviyang35 commented Apr 5, 2019

vikmeup commented Apr 5, 2019

daviyang35 commented Apr 7, 2019

codecov bot commented Apr 7, 2019 • edited Loading

Codecov Report

hewigovens commented Apr 8, 2019

daviyang35 commented Apr 9, 2019

hewigovens left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Apr 7, 2019 •

edited

Loading

hewigovens left a comment •

edited

Loading