Address locked binding issue #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: milevavantuyl <mvantuyl@wellesley.edu>
milevavantuyl
force-pushed
the
locked-binding
branch
from
e26f473
to
60cdda8
Compare
Signed-off-by: milevavantuyl <mvantuyl@wellesley.edu>
SSaishruthi
requested changes
Jun 7, 2022
aif360/aif360-r/README.Rmd
Outdated
| @@ -116,6 +116,8 @@ load_aif360_lib() | |||
| load_aif360_lib() | |||
| ``` | |||
|
|
|||
| If you get an error: `cannot change value of locked binding`, please restart the R session and run `load_aif360_lib()` exactly once. | |||
There was a problem hiding this comment.
Add function to load the library.
Signed-off-by: milevavantuyl <mvantuyl@wellesley.edu>
SSaishruthi
approved these changes
Jun 23, 2022
aif360/aif360-r/R/import.R
Outdated
| lockBinding("post_algo", e) | ||
| lockBinding("tf", e) | ||
| } else { | ||
| message(paste0(c("The aif360 functions have already been loaded:", bindings), sep = " ")) |
There was a problem hiding this comment.
Two suggestions.
- Let's not display all the functions as it is not required for the users
- Expand the message to something like
The aif360 functions have already been loaded. You can begin using the package
SSaishruthi
requested changes
Jun 23, 2022
Signed-off-by: milevavantuyl <mvantuyl@wellesley.edu>
Illia-Kryvoviaz
pushed a commit
to Illia-Kryvoviaz/AIF360
that referenced
this pull request
Jun 7, 2023
Address locked binding issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README instructions and code for loading aif360 functions to address issue #298 about locked binding