Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sklearn-compatible algorithms #318

Merged
merged 88 commits into from
Jul 1, 2022
Merged

More sklearn-compatible algorithms #318

merged 88 commits into from
Jul 1, 2022

Conversation

hoffmansc
Copy link
Collaborator

Samuel Hoffman and others added 30 commits December 19, 2019 12:49
* dataset loading is more similar to sklearn.datasets
* label binarization is now done outside standardize_dataset
* metrics use 'groups' and 'priv_group' to signify priv/unpriv split
removed Reweighing.sample_weight_ attribute
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
* postprocessors need 'requires_proba' tag
* no default postprocessor
* fix prefit, score PostProcessingMeta bugs

Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
* add fit_predict
* add sample_weight warning

Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jun 29, 2022

This pull request introduces 1 alert and fixes 1 when merging f978b5f into 89f700b - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

fixed alerts:

  • 1 for Conflicting attributes in base classes

Copy link
Collaborator

@mnagired mnagired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both notebooks (LFR and ROC) look good to go :)

@hoffmansc hoffmansc added this to the sklearn-compat milestone Jun 29, 2022
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2022

This pull request introduces 1 alert and fixes 1 when merging 35f87a7 into 38368c5 - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

fixed alerts:

  • 1 for Conflicting attributes in base classes

@hoffmansc hoffmansc merged commit 0a5c852 into master Jul 1, 2022
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
* new ROC and LFR implementations

* allow prot_attr/target input to be Series

* LFR uses pytorch to calculate grad

* change defaults in metaestimators

* clean up tests

* infer proba behavior for PostProcessingMeta from estimator 'requires_proba' tag

* fix prefit, score PostProcessingMeta bugs

* propagate classes_ in metaestimators

Signed-off-by: Samuel Hoffman <hoffman.sc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants