Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes deprecated Numpy scalar type names #1296

Merged
merged 20 commits into from
Dec 3, 2021

Conversation

beat-buesser
Copy link
Collaborator

Description

This pull request removes deprecated Numpy scalar type names.

Fixes #1204

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Beat Buesser added 4 commits July 2, 2021 00:20
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this Sep 1, 2021
@beat-buesser beat-buesser added the improvement Improve implementation label Sep 1, 2021
@beat-buesser beat-buesser added this to Pull request open in ART 1.8.0 via automation Sep 1, 2021
@beat-buesser beat-buesser added this to the ART 1.8.0 milestone Sep 1, 2021
@beat-buesser beat-buesser linked an issue Sep 1, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1296 (1d99d87) into dev_1.9.0 (74512a8) will increase coverage by 0.08%.
The diff coverage is 89.16%.

Impacted file tree graph

@@              Coverage Diff              @@
##           dev_1.9.0    #1296      +/-   ##
=============================================
+ Coverage      90.45%   90.54%   +0.08%     
=============================================
  Files            234      234              
  Lines          18993    18993              
  Branches        3349     3349              
=============================================
+ Hits           17181    17198      +17     
+ Misses          1044     1033      -11     
+ Partials         768      762       -6     
Impacted Files Coverage Δ
...asion/adversarial_patch/adversarial_patch_numpy.py 75.53% <ø> (ø)
...ion/adversarial_patch/adversarial_patch_pytorch.py 83.84% <ø> (ø)
.../adversarial_patch/adversarial_patch_tensorflow.py 82.52% <ø> (ø)
...attacks/evasion/auto_projected_gradient_descent.py 86.61% <0.00%> (ø)
art/attacks/evasion/dpatch.py 90.79% <ø> (ø)
...adient_descent/projected_gradient_descent_numpy.py 89.15% <0.00%> (ø)
art/defences/preprocessor/preprocessor.py 76.36% <0.00%> (ø)
art/preprocessing/audio/l_filter/numpy.py 90.14% <0.00%> (ø)
art/attacks/evasion/fast_gradient.py 84.54% <16.66%> (ø)
...timators/speech_recognition/pytorch_deep_speech.py 93.62% <50.00%> (ø)
... and 46 more

@lgtm-com
Copy link

lgtm-com bot commented Sep 2, 2021

This pull request introduces 1 alert when merging 025fa05 into bb5b5c1 - view on LGTM.com

new alerts:

  • 1 for Unused import

BEAT BUESSER and others added 7 commits September 2, 2021 15:29
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Copy link
Collaborator

@minhitbk minhitbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@beat-buesser beat-buesser removed this from Pull request open in ART 1.8.0 Sep 24, 2021
@beat-buesser beat-buesser removed this from the ART 1.8.0 milestone Sep 24, 2021
@beat-buesser beat-buesser changed the base branch from dev_1.8.0 to main September 25, 2021 23:44
@beat-buesser beat-buesser added this to Pull request open in ART 1.9.0 via automation Sep 29, 2021
@beat-buesser beat-buesser added this to the ART 1.9.0 milestone Sep 29, 2021
@lgtm-com
Copy link

lgtm-com bot commented Oct 11, 2021

This pull request introduces 1 alert when merging f1d7c16 into 2fadf9b - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2021

This pull request introduces 1 alert when merging 685a070 into 1a5e026 - view on LGTM.com

new alerts:

  • 1 for Unused import

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser changed the base branch from main to dev_1.9.0 October 12, 2021 21:10
@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2021

This pull request introduces 1 alert when merging bf44dbd into 24daff1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 12, 2021

This pull request introduces 1 alert when merging bf44dbd into 1a5e026 - view on LGTM.com

new alerts:

  • 1 for Unused import

@beat-buesser beat-buesser merged commit 451d909 into dev_1.9.0 Dec 3, 2021
ART 1.9.0 automation moved this from Pull request open to Pull request done Dec 3, 2021
@beat-buesser beat-buesser deleted the development_issue_1204 branch December 3, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.9.0
  
Pull request done
Development

Successfully merging this pull request may close these issues.

Using the aliases of builtin types like np.int is deprecated¶
3 participants