Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a classifier on Jax framework #1360

Merged
merged 32 commits into from
Dec 16, 2021
Merged

Conversation

minhitbk
Copy link
Collaborator

@minhitbk minhitbk commented Oct 15, 2021

Description

This PR is to implement a classifier on the Jax framework.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
@minhitbk minhitbk added the enhancement New feature or request label Oct 15, 2021
@minhitbk minhitbk added this to Pull request open in ART 1.9.0 via automation Oct 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #1360 (448958a) into dev_1.9.0 (4f41ea7) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           dev_1.9.0    #1360      +/-   ##
=============================================
- Coverage      90.31%   89.90%   -0.41%     
=============================================
  Files            240      244       +4     
  Lines          19672    19759      +87     
  Branches        3490     3495       +5     
=============================================
- Hits           17766    17764       -2     
- Misses          1109     1198      +89     
  Partials         797      797              
Impacted Files Coverage Δ
art/experimental/__init__.py 0.00% <0.00%> (ø)
...experimental/estimators/classification/__init__.py 0.00% <0.00%> (ø)
art/experimental/estimators/classification/jax.py 0.00% <0.00%> (ø)
art/experimental/estimators/jax.py 0.00% <0.00%> (ø)
art/utils.py 91.13% <ø> (-0.02%) ⬇️
art/attacks/evasion/boundary.py 92.72% <0.00%> (-1.22%) ⬇️
art/defences/detector/poison/activation_defence.py 85.18% <0.00%> (+0.33%) ⬆️

Signed-off-by: Ngoc Minh Tran <M.N.Tran@ibm.com>
@beat-buesser beat-buesser self-assigned this Oct 15, 2021
@beat-buesser beat-buesser added this to the ART 1.9.0 milestone Oct 15, 2021
@beat-buesser beat-buesser linked an issue Oct 15, 2021 that may be closed by this pull request
beat-buesser and others added 2 commits November 12, 2021 23:57
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2021

This pull request introduces 1 alert when merging 064e369 into 2717467 - view on LGTM.com

new alerts:

  • 1 for Unused import

Beat Buesser added 4 commits November 15, 2021 22:51
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-requested a review December 7, 2021 12:03
@beat-buesser beat-buesser merged commit 16e84e4 into dev_1.9.0 Dec 16, 2021
ART 1.9.0 automation moved this from Pull request open to Pull request done Dec 16, 2021
@beat-buesser beat-buesser deleted the dev_jax_estimator branch December 16, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
ART 1.9.0
  
Pull request done
Development

Successfully merging this pull request may close these issues.

Investigate support for JAX
3 participants