Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for framework-specific preprocessing of object arrays #1702

Merged
merged 10 commits into from
May 23, 2022

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser beat.buesser@ie.ibm.com

Description

This pull request adds support for framework-specific preprocessing of object arrays.

Fixes #1683

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@beat-buesser beat-buesser self-assigned this May 17, 2022
@beat-buesser beat-buesser added the improvement Improve implementation label May 17, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.10.2 via automation May 17, 2022
@beat-buesser beat-buesser added this to the ART 1.10.2 milestone May 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1702 (1c81523) into dev_1.10.2 (af9bf9c) will increase coverage by 0.07%.
The diff coverage is 92.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.10.2    #1702      +/-   ##
==============================================
+ Coverage       88.04%   88.12%   +0.07%     
==============================================
  Files             259      263       +4     
  Lines           21398    21964     +566     
  Branches         3800     3918     +118     
==============================================
+ Hits            18840    19355     +515     
- Misses           1607     1649      +42     
- Partials          951      960       +9     
Impacted Files Coverage Δ
...t/defences/preprocessor/mp3_compression_pytorch.py 95.74% <80.00%> (-4.26%) ⬇️
...timators/speech_recognition/pytorch_deep_speech.py 94.11% <100.00%> (+0.41%) ⬆️
art/estimators/gan/tensorflow.py 66.07% <0.00%> (ø)
...g/backdoor_attack_dgm/backdoor_attack_dgm_trail.py 95.34% <0.00%> (ø)
...mators/object_detection/pytorch_object_detector.py 79.21% <0.00%> (ø)
...ing/backdoor_attack_dgm/backdoor_attack_dgm_red.py 90.90% <0.00%> (ø)
art/defences/detector/poison/activation_defence.py 84.61% <0.00%> (+0.33%) ⬆️
art/estimators/pytorch.py 83.62% <0.00%> (+0.86%) ⬆️
art/attacks/evasion/carlini.py 95.78% <0.00%> (+1.12%) ⬆️
... and 5 more

Beat Buesser added 2 commits May 18, 2022 00:37
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 1 alert when merging 224d038 into 3a3bedf - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

Beat Buesser added 5 commits May 23, 2022 17:42
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 1 alert when merging 6e436c3 into 3a3bedf - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 1 alert when merging 25d96be into 3a3bedf - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 1 alert when merging 1c81523 into 3a3bedf - view on LGTM.com

new alerts:

  • 1 for Module is imported more than once

@beat-buesser beat-buesser merged commit 8ba938d into dev_1.10.2 May 23, 2022
ART 1.10.2 automation moved this from Pull request open to Pull request done May 23, 2022
@beat-buesser beat-buesser deleted the development_issue_1683 branch May 23, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.10.2
  
Pull request done
Development

Successfully merging this pull request may close these issues.

PreprocessorPyTorch preprocessor cannot be used with PyTorchDeepSpeech class
2 participants