-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small clarification fix for verification alg #1890
Conversation
Codecov Report
@@ Coverage Diff @@
## dev_1.12.2 #1890 +/- ##
==============================================
- Coverage 85.85% 76.23% -9.62%
==============================================
Files 248 248
Lines 23312 23315 +3
Branches 4212 4213 +1
==============================================
- Hits 20015 17775 -2240
- Misses 2232 4614 +2382
+ Partials 1065 926 -139
|
Signed-off-by: Kevin Eykholt <kheykholt@ibm.com>
f8bf2e2
to
4dfd585
Compare
Signed-off-by: Kevin Eykholt <kheykholt@ibm.com>
This pull request introduces 1 alert when merging 535e305 into dc29bbc - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 4559032 into dc29bbc - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @keykholt Thank you very much! It looks good to me.
Description
In verification_decisions_trees.py, the code does not specify that the input data need to be in the [0,1] range. It also only permits one-hot vectors as inputs for y. I've made some small changes to check the input data range and to format the data if
y
is in the shape(nb_samples, 1)Type of change
Please check all relevant options.
Checklist