Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small clarification fix for verification alg #1890

Merged
merged 6 commits into from
Nov 1, 2022

Conversation

keykholt
Copy link
Collaborator

Description

In verification_decisions_trees.py, the code does not specify that the input data need to be in the [0,1] range. It also only permits one-hot vectors as inputs for y. I've made some small changes to check the input data range and to format the data if y is in the shape(nb_samples, 1)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #1890 (4559032) into dev_1.12.2 (dc29bbc) will decrease coverage by 9.61%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.12.2    #1890      +/-   ##
==============================================
- Coverage       85.85%   76.23%   -9.62%     
==============================================
  Files             248      248              
  Lines           23312    23315       +3     
  Branches         4212     4213       +1     
==============================================
- Hits            20015    17775    -2240     
- Misses           2232     4614    +2382     
+ Partials         1065      926     -139     
Impacted Files Coverage Δ
art/metrics/verification_decisions_trees.py 90.71% <50.00%> (-0.96%) ⬇️
art/attacks/evasion/carlini.py 7.55% <0.00%> (-86.74%) ⬇️
art/attacks/evasion/graphite/utils.py 10.37% <0.00%> (-79.25%) ⬇️
...s/extraction/functionally_equivalent_extraction.py 14.19% <0.00%> (-78.40%) ⬇️
art/attacks/evasion/decision_tree_attack.py 23.28% <0.00%> (-76.72%) ⬇️
art/attacks/evasion/graphite/graphite_blackbox.py 9.12% <0.00%> (-76.50%) ⬇️
...acks/evasion/graphite/graphite_whitebox_pytorch.py 9.85% <0.00%> (-75.87%) ⬇️
art/attacks/extraction/knockoff_nets.py 20.13% <0.00%> (-69.80%) ⬇️
art/attacks/evasion/adversarial_patch/utils.py 11.53% <0.00%> (-69.24%) ⬇️
art/attacks/evasion/hclu.py 30.90% <0.00%> (-69.10%) ⬇️
... and 21 more

Signed-off-by: Kevin Eykholt <kheykholt@ibm.com>
Signed-off-by: Kevin Eykholt <kheykholt@ibm.com>
@beat-buesser beat-buesser self-requested a review October 20, 2022 22:52
@beat-buesser beat-buesser self-assigned this Oct 20, 2022
@beat-buesser beat-buesser added the improvement Improve implementation label Oct 20, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.12.2 via automation Oct 20, 2022
@beat-buesser beat-buesser added this to the ART 1.12.2 milestone Oct 20, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 25, 2022

This pull request introduces 1 alert when merging 535e305 into dc29bbc - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Nov 1, 2022

This pull request introduces 2 alerts when merging 4559032 into dc29bbc - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @keykholt Thank you very much! It looks good to me.

@beat-buesser beat-buesser merged commit ef53a70 into Trusted-AI:dev_1.12.2 Nov 1, 2022
ART 1.12.2 automation moved this from Pull request open to Pull request done Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.12.2
  
Pull request done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants