Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix sleeper agent #1892

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

monshri
Copy link
Contributor

@monshri monshri commented Oct 27, 2022

Description

When the loss is nan or inf, then best_x_poisoned is never assigned, leading to the error mentioned in

Fixes # (1865)

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Shriti Priya <shritip@ibm.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #1892 (efffe13) into dev_1.12.2 (dc29bbc) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           dev_1.12.2    #1892      +/-   ##
==============================================
- Coverage       85.85%   85.83%   -0.02%     
==============================================
  Files             248      248              
  Lines           23312    23317       +5     
  Branches         4212     4213       +1     
==============================================
  Hits            20015    20015              
- Misses           2232     2236       +4     
- Partials         1065     1066       +1     
Impacted Files Coverage Δ
art/attacks/poisoning/sleeper_agent_attack.py 40.30% <0.00%> (-1.06%) ⬇️

@beat-buesser beat-buesser self-requested a review October 28, 2022 17:27
@beat-buesser beat-buesser self-assigned this Oct 28, 2022
@beat-buesser beat-buesser added the improvement Improve implementation label Oct 28, 2022
@beat-buesser beat-buesser added this to Pull request open in ART 1.12.2 via automation Oct 28, 2022
@beat-buesser beat-buesser added this to the ART 1.12.2 milestone Oct 28, 2022
@beat-buesser beat-buesser linked an issue Oct 28, 2022 that may be closed by this pull request
@beat-buesser beat-buesser changed the base branch from main to dev_1.12.2 October 28, 2022 17:28
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2022

This pull request introduces 2 alerts when merging efffe13 into dc29bbc - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2022

This pull request introduces 2 alerts when merging f6e7c2c into dc29bbc - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

Copy link
Collaborator

@beat-buesser beat-buesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @monshri Thank you very much! It looks good to me.

@beat-buesser beat-buesser merged commit 0261594 into Trusted-AI:dev_1.12.2 Nov 1, 2022
ART 1.12.2 automation moved this from Pull request open to Pull request done Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve implementation
Projects
No open projects
ART 1.12.2
  
Pull request done
Development

Successfully merging this pull request may close these issues.

Sleeper Agent Attack - issues with nan
3 participants