-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy data generators #1934
numpy data generators #1934
Conversation
Signed-off-by: David Slater <davidslater@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## dev_1.13.0 #1934 +/- ##
===============================================
+ Coverage 69.53% 85.60% +16.07%
===============================================
Files 257 257
Lines 23890 23927 +37
Branches 4340 4346 +6
===============================================
+ Hits 16611 20482 +3871
+ Misses 6339 2335 -4004
- Partials 940 1110 +170
|
This pull request introduces 2 alerts when merging e6c64f2 into e7c763b - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Signed-off-by: David Slater <davidslater@users.noreply.github.com>
Signed-off-by: David Slater <davidslater@users.noreply.github.com>
1c79275
to
162dd27
Compare
This pull request introduces 2 alerts when merging 162dd27 into e7c763b - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 2 alerts when merging 162dd27 into 6e82fe1 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Signed-off-by: David Slater <davidslater@users.noreply.github.com>
Signed-off-by: David Slater <davidslater@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidslater Looks good to me! Thank you very much!
Signed-off-by: David Slater davidslater@users.noreply.github.com
Description
This PR adds a NumpyDataGenerator class that is backed by numpy arrays. This can be useful for avoiding OOM errors when using framework-specific model fitting.
Fixes #1926
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
tests/test_data_generators.py::TestNumpyDataGenerator
Test Configuration:
Checklist