Switch all client tests to jest #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkvon
approved these changes
Jan 8, 2020
There was a problem hiding this comment.
Impressive configuration changes! That must have been challenging to make it run smoothly.
Tests work and test count matches the previous version perfectly!
What I understand, looks good to me.
Disclaimer: I don't understand a majority of changes. 🙂
So let's wait for the merge of #1167 and then i support merge.
mrkvon
reviewed
Jan 8, 2020
| @@ -1,9 +1,24 @@ | |||
| module.exports = { | |||
| moduleNameMapper: { | |||
| '@/(.*)$': '<rootDir>/$1', | |||
| '^@/(.*)$': '<rootDir>/$1', | |||
There was a problem hiding this comment.
😲 Whatever the stuff in this config is doing, it works!
nicksellen
force-pushed
the
remove-karma
branch
from
2fe3c4d
to
3a11a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Now we have jest for frontend tests, we can remove karma. This makes the minimal changes needed to get the existing client tests to run under jest.
Built on top of #1167 so that should be merged first.
Testing Instructions