Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Added edit webhook modal #1056

Merged
merged 7 commits into from Oct 19, 2018
Merged

Conversation

kevinansfield
Copy link
Collaborator

@kevinansfield kevinansfield commented Oct 18, 2018

requires TryGhost/Ghost#10033

  • added settings.integration.webhooks.edit route
    • /integrations/:integration_id/webhooks/:webhook_id
  • added error handling to the webhook form modal that copes with the actual errors we get back from the server
  • added event-name helper to display humanised event names in the webhooks list
  • added delete button to the webhooks list and associated confirmation modal

TODO:

  • tests

no issue
- display "last seen" time if available for API keys
- use CSS to for hover behaviour instead of JS toggle
- add background to "copy" button so it's visible when on top of key data
- use ember-concurrency tasks instead of actions and used the derived state to show a temporary "copied to clipboard" message in place of the "last seen at" time
requires TryGhost/Ghost#10033
- added `settings.integration.webhooks.edit` route
  - `/integrations/:integration_id/webhooks/:webhook_id`
@kevinansfield kevinansfield changed the title [WIP] Added edit webhook modal Added edit webhook modal Oct 19, 2018
@kevinansfield kevinansfield merged commit eeaa5f0 into TryGhost:master Oct 19, 2018
@kevinansfield kevinansfield deleted the edit-webhooks branch October 19, 2018 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant