Added edit webhook route to v2 Admin API #10033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Oct 18, 2018
requires TryGhost/Ghost#10033 - added `settings.integration.webhooks.edit` route - `/integrations/:integration_id/webhooks/:webhook_id`
1 task
kevinansfield
force-pushed
the
webhooks-edit
branch
from
c4df149
to
fb499b7
Compare
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Oct 18, 2018
requires TryGhost/Ghost#10033 - added `settings.integration.webhooks.edit` route - `/integrations/:integration_id/webhooks/:webhook_id`
no issue - webhooks UI requires the ability to edit webhooks - added `edit` permission for `webhook` - added `edit` method to v2 webhook controller - added `PUT /webhooks/:id` route to v2 Admin API routes
rishabhgrg
force-pushed
the
webhooks-edit
branch
from
6e715a9
to
14e629c
Compare
kevinansfield
added a commit
to TryGhost/Admin
that referenced
this pull request
Oct 19, 2018
requires TryGhost/Ghost#10033 - added `settings.integration.webhooks.edit` route - `/integrations/:integration_id/webhooks/:webhook_id` - added error handling to the webhook form modal that copes with the actual errors we get back from the server - added `event-name` helper to display humanised event names in the webhooks list - added delete button to the webhooks list and associated confirmation modal
kevinansfield
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
editpermission forwebhookeditmethod to v2 webhook controllerPUT /webhooks/:idroute to v2 Admin API routes