This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
display a spinner whilst the app is loading #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acburdine
suggested changes
Jan 13, 2017
There was a problem hiding this comment.
To make this work the ember-load dependency needs to be installed and the requisite {{ember-load-remover}} component added to the application.hbs template.
|
Strange, looks like the files got missed in my commit 😕 |
no issue - use the same loading indicator as used on my.ghost.org - will display whilst the JS is loading and initializing rather than showing a completely blank screen
kevinansfield
force-pushed
the
loading-screen
branch
from
10c356d
to
e6ba370
Compare
|
@acburdine added the missing files 👍 |
acburdine
approved these changes
Jan 15, 2017
|
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue