Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

General UI improvements. #630

Merged
merged 31 commits into from
Apr 10, 2017
Merged

General UI improvements. #630

merged 31 commits into from
Apr 10, 2017

Conversation

disordinary
Copy link
Contributor

@disordinary disordinary commented Apr 10, 2017 •
edited
Loading

Refs: TryGhost/Ghost#8248
Refs: TryGhost/Ghost#8194
Closes: TryGhost/Ghost#8192

Miscellaneous reliability and usability fixes.

  • Improve the reliability of selection.
  • Ensure that the + menu appears even if there is a blank document (which meant the events weren't firing from mobiledoc itself)
  • When cards are added they are automatically selected and if possible go straight into edit mode (only works on the markdown card).
  • Fixes issues in Safari desktop, Safari mobile, and Firefox.
  • Tries to position UI on screen at all times.
  • Removes fastclick.

@disordinary
give the HR card the same logic as the img card for replacing the cur…
553b04d 
…rent post or inserting afterwards.
@disordinary
remove defult to edit in html card, defer edit decisions to the man
4b42358
@disordinary
new cards are now selected, transition in, and if possible are edited…
117fa1b 
… straight away
@disordinary
Get cursor movement working in Safari and Firefox
0df1759
@disordinary
when you lose the focus on the editor and try and add a card to a bla…
56dfbef 
…nk part you get an error. This fix stores the range when the + menu is created.
@disordinary
make + menu appear on blank document
c83234b
@disordinary
Add minimum height to cards and fix a but in card selection
7162002
@disordinary
animate card creation
2d231c6
@disordinary
remove needless logging
c625def
@disordinary
if card does not default to edit mode then hard-select it rather than…
0812c68 
… soft
@disordinary
navigate between card sections with keyboard
39f1749
@disordinary
when a card is placed at the top of the editor and added via the / me…
287439e 
…nu it can't figure out the id with jquery and so we fall back to plain old dom.
@disordinary
make cards inline-block so there isn't a line above and below them
6b08966
@disordinary
kind of position the menu near the range and scroll the editor if the…
56a8e24 
… cursor is off screen in safari.
@disordinary
fixes the toolbar appearing in a card in firefox bug and ensures the …
a8be4db 
…toolbar sits above the title
@disordinary
fade in and out card menus
6ad79c4
@disordinary
make sure card menus are always on screen when created.
1786bb3
@disordinary
remove border around HTML card
d12219c
@disordinary
ensure the '/' menu doesn't overflow the right hand side of the edito…
ac02558 
…r when created.
@disordinary
make sure that the toolbar is always on screen, try and make the 'tic…
ad398ae 
…k' move to fix this.
@disordinary
make sure the toolbar appears on screen vertically
b67f0db
@disordinary
adjusted toolbar movement ratio
39ae231
@disordinary
added mobile toolbar, fixed some CSS issues that was stopping the edi…
7048c7b 
…tor on mobile, and removed fastclick support.
@disordinary
fix safari layout issues.
e705a4d
@disordinary
When a menu is open the title doesn't want to capture keyboard events.
783950e
@disordinary
cleaned up some code a bit.
123d2f4
@disordinary
keep everything except the editor border-box.
6628a57
@disordinary
make content selectable underneith a card toolbar.
ffa3737
@disordinary
remove fastclick
5b1f3a8
@disordinary
updated for linting and fixed tests.
9f9824d
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 73.915% when pulling 9f9824d on disordinary:son-of-all-the-things-redux into 954ac1a on TryGhost:master.

@disordinary disordinary changed the title [WIP] General UI improvements. General UI improvements. Apr 10, 2017
@kevinansfield kevinansfield merged commit 4670d3f into TryGhost:master Apr 10, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 73.869% when pulling ae5ef81 on disordinary:son-of-all-the-things-redux into 954ac1a on TryGhost:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@disordinary @coveralls @kevinansfield