Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari on iOS editor isssues #8192

Closed
4 tasks done
disordinary opened this issue Mar 20, 2017 · 2 comments · Fixed by TryGhost/Admin#630
Closed
4 tasks done

Safari on iOS editor isssues #8192

disordinary opened this issue Mar 20, 2017 · 2 comments · Fixed by TryGhost/Admin#630
Labels
affects:editor Work relating to the Koenig Editor
Milestone

Comments

@disordinary
Copy link
Contributor

disordinary commented Mar 20, 2017

Safari in iOS has a few issues:

  • You cannot tap on the editor to select it.
  • The toolbar is hidden by the iOS cut/copy/paste toolbar when text is selected.
  • The / menu is not placed in the correct location.
  • We need to ensure that all elements are located on screen, right now the '/' menu is not located properly and the '+' menu appears off the screen when it's too narrow.
@kirrg001 kirrg001 added this to the 1.0.0 Beta Ready milestone Mar 20, 2017
@ErisDS ErisDS added the affects:editor Work relating to the Koenig Editor label Mar 20, 2017
@kevinansfield kevinansfield modified the milestones: 1.0.0 Launch, 1.0.0 Beta Ready Apr 3, 2017
@disordinary
Copy link
Contributor Author

disordinary commented Apr 8, 2017

This issue only occurs on iOS safari, on Android both Chrome and mobile Firefox work as expected.

This issue also occurs on any contenteditable div within the ghost-admin interface on Safari and so it's not isolated to the editor. The editor also works in isolation from ghost-admin.

In settings the code-injection codemirror elements also has the same problem.

Right now a user can edit content but it's a pain, they have to hold to select the text they want to edit and then tap that selection. Otherwise it's actually a nice experience on the ipad, on an android phone the UI is a little claustrophobic.

@disordinary
Copy link
Contributor Author

disordinary commented Apr 9, 2017

This issue is caused by three things:

  1. The fastclick library.
  2. A global line-height on body.
  3. Wildcard box-sizing: border-box

Obviously 2 and 3 are easily fixable. 1 is the biggest problem.

The fastclick library has a facility to ignore elements with a class of needsclick this works on the heading but not on the mobiledoc. There are numerous issues on draft.js about this so mobiledoc is not alone.

Fast click no longer appears to be needed with modern mobile platforms so my suggestion would be that we remove it.

kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Apr 10, 2017
refs TryGhost/Ghost#8248
refs TryGhost/Ghost#8194
closes TryGhost/Ghost#8192

Miscellaneous editor reliability and usability fixes. 
- Improve the reliability of selection.
- Ensure that the + menu appears even if there is a blank document (which meant the events weren't firing from mobiledoc itself)
- When cards are added they are automatically selected and if possible go straight into edit mode (only works on the markdown card).
- Fixes issues in Safari desktop, Safari mobile, and Firefox.
- Tries to position UI on screen at all times.
- Removes fastclick.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:editor Work relating to the Koenig Editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants