This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
add "delete post" button to the PSM #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost/Ghost#8332 - moves `toggleDeletePostModal` action from the `edit` controller to the `editor-base-controller` mixin - adds delete button to the bottom of the PSM unless it's a new post - adds `deletePost` attribute to `gh-post-settings-menu` to allow a delete post action to be passed in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8332
toggleDeletePostModalaction from theeditcontroller to theeditor-base-controllermixindeletePostattribute togh-post-settings-menuto allow a delete post action to be passed inNote: this PR adds the necessary functionality but the styling for settings menu delete buttons is currently broken (TryGhost/Ghost#8345) and will be fixed in a separate PR