This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🐛 Make cmd+s work for all save-buttons
#700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinansfield
suggested changes
May 17, 2017
There was a problem hiding this comment.
Fix looks good 👍 I think this would be a good time to ensure that we're testing the CMD-S behaviour - it's something we've had issues with before too.
I've pushed a commit with a test for settings/general (I wanted to make sure it was possible before asking!), hopefully it'll be pretty easy to duplicate to the tests for other screens 😄
|
Awesome!! Will adapt it for the other changes as well! |
aileen
force-pushed
the
fix-save-keyboard-shortcut
branch
from
c888195
to
21f102e
Compare
|
Added tests @kevinansfield to wherever we have a |
|
Hmmm.... That's weird... The tests pass all locally... 🤔 |
closes TryGhost/Ghost#8443 Fixes a bug where the keyboard shortcut `cmd+s` would cause a `Maximum call stack size` error and not save. Wherever there is a `save` button, the keyboard shortcut to save works now.
aileen
force-pushed
the
fix-save-keyboard-shortcut
branch
from
21f102e
to
d61b9f5
Compare
kevinansfield
approved these changes
May 18, 2017
|
It's ✅! 😁 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8443
Fixes a bug where the keyboard shortcut
cmd+swould cause aMaximum call stack sizeerror and not save.Wherever there is a
savebutton, the keyboard shortcut to save works now.