This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
馃悰 fix IE11 bugs and styles #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost/Ghost#8384 - fixes image uploads on settings/general by reverting to jQuery for triggering the file dialog because IE11 doesn't support `MouseEvent` events or have the `.closest` method on native DOM elements - gives all SVG elements an explicit `width` and `height` - if one property is set to `auto` or not specified IE11 will treat it as 100% of the container - fixes horizontal scroll + scrollbar on the main app viewport
kirrg001
approved these changes
Jun 1, 2017
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Jul 10, 2017
closes TryGhost/Ghost#8665 - updates width/height for non-square icons to match the desired dimensions (width+height have to be specified for IE11) Changes introduced in TryGhost#724 failed to take into account a few of our icons are not square (notably the `arrow-*-small.svg` icons) resulting in some icons appearing too small.
kirrg001
pushed a commit
that referenced
this pull request
Jul 10, 2017
closes TryGhost/Ghost#8665 - updates width/height for non-square icons to match the desired dimensions (width+height have to be specified for IE11) Changes introduced in #724 failed to take into account a few of our icons are not square (notably the `arrow-*-small.svg` icons) resulting in some icons appearing too small.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8384
MouseEventevents or have the.closestmethod on native DOM elementswidthandheight- if one property is set toautoor not specified IE11 will treat it as 100% of the container