Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost 1.0: SVG icons not displaying correctly in IE11 #8384

Closed
disordinary opened this issue Apr 25, 2017 · 0 comments · Fixed by TryGhost/Admin#724
Closed

Ghost 1.0: SVG icons not displaying correctly in IE11 #8384

disordinary opened this issue Apr 25, 2017 · 0 comments · Fixed by TryGhost/Admin#724
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@disordinary
Copy link
Contributor

disordinary commented Apr 25, 2017 •
edited
Loading

Issue Summary

When viewing Ghost in IE 11 the new SVG icons are often slightly off.

  1. On the login screen the icons appear in the middle of inputs.
  2. In the editor toolbar the quote icon isn't vertically centred.
  3. In the editor card-toolbar the trash icon is extremely wide.

1:
virtualbox_win_25_04_2017_17_41_52

2:
virtualbox_win_25_04_2017_17_41_21

3:
virtualbox_win_25_04_2017_17_40_35

Steps to Reproduce

  1. Open Ghost 1.0 in IE 11.
  2. Navigate to the login screen.
  3. Navigate to the editor and select text.
  4. Navigate to the editor and select a card.

Technical details:
@disordinary disordinary changed the title SVG icons not displaying correctly in IE11 Ghost 1.0: SVG icons not displaying correctly in IE11 Apr 25, 2017
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly css labels Apr 25, 2017
@kevinansfield kevinansfield added this to the 1.0.0 Launch milestone Apr 25, 2017
@kirrg001 kirrg001 removed this from the 1.0.0 Backlog milestone May 12, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jun 1, 2017
@kevinansfield
🐛 fix IE11 bugs and styles
d7fcfa9 
closes TryGhost/Ghost#8384
- fixes image uploads on settings/general by reverting to jQuery for triggering the file dialog because IE11 doesn't support `MouseEvent` events or have the `.closest` method on native DOM elements
- gives all SVG elements an explicit `width` and `height` - if one property is set to `auto` or not specified IE11 will treat it as 100% of the container
- fixes horizontal scroll + scrollbar on the main app viewport
@kevinansfield kevinansfield mentioned this issue Jun 1, 2017
Merged
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue Jun 1, 2017
@kevinansfield @kirrg001
🐛 fix IE11 bugs and styles (#724)
43a1811 
closes TryGhost/Ghost#8384

- fixes image uploads on settings/general by reverting to jQuery for triggering the file dialog because IE11 doesn't support `MouseEvent` events or have the `.closest` method on native DOM elements
- gives all SVG elements an explicit `width` and `height` - if one property is set to `auto` or not specified IE11 will treat it as 100% of the container
- fixes horizontal scroll + scrollbar on the main app viewport
@kirrg001 kirrg001 mentioned this issue Jun 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix IE11 bugs and styles kevinansfield/Ghost-Admin
3 participants
@kevinansfield @disordinary @kirrg001