This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
🐛 fix Cmd-S save with cursor in slug field #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes TryGhost/Ghost#8551 - move `updateSlug` logic from `gh-post-settings-menu` component to `editor-base-controller` mixin - put `updateSlug` and `save` into a task group so that concurrent calls are queued - means that pressing Cmd-S with the cursor still in the slug field will first trigger the `updateSlug` call (triggered by the field blur) then trigger the `save` call (triggered by Cmd-S) when `updateSlug` has finished so there are no conflicts and you still see the "saved" notification
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes TryGhost/Ghost#8551
updateSluglogic fromgh-post-settings-menucomponent toeditor-base-controllermixinupdateSlugandsaveinto a task group so that concurrent calls are queued - means that pressing Cmd-S with the cursor still in the slug field will first trigger theupdateSlugcall (triggered by the field blur) then trigger thesavecall (triggered by Cmd-S) whenupdateSlughas finished so there are no conflicts and you still see the "saved" notification