-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error from CMD+S whilst cursor is in post slug field #8551
Labels
Milestone
Comments
This happens also on LTS (see #8563). |
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jun 13, 2017
refs TryGhost/Ghost#8551 - renames editor-base-controller.generateSlug to generateSlugFromTitle - moves `updateSlug` logic from PSM to editor base controller - moves editor base controller save logic into a `save` task - adds `updateSlug` and `save` into a `saveTasks` task group so that calls are queued rather than running concurrently - sets the editor controller on the PSM when accessing the new/edit routes - we use a base controller mixin so the slug/save logic is duplicated on new/edit controllers meaning we need to add a reference manually rather than relying on dependency injection - remove titleObserver checks for non-existent titleObserver
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jun 13, 2017
refs TryGhost/Ghost#8551 - renames editor-base-controller.generateSlug to generateSlugFromTitle - moves `updateSlug` logic from PSM to editor base controller - moves editor base controller save logic into a `save` task - adds `updateSlug` and `save` into a `saveTasks` task group so that calls are queued rather than running concurrently - sets the editor controller on the PSM when accessing the new/edit routes - we use a base controller mixin so the slug/save logic is duplicated on new/edit controllers meaning we need to add a reference manually rather than relying on dependency injection - remove titleObserver checks for non-existent titleObserver
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jun 13, 2017
refs TryGhost/Ghost#8551 - renames editor-base-controller.generateSlug to generateSlugFromTitle - moves `updateSlug` logic from PSM to editor base controller - moves editor base controller save logic into a `save` task - adds `updateSlug` and `save` into a `saveTasks` task group so that calls are queued rather than running concurrently - sets the editor controller on the PSM when accessing the new/edit routes - we use a base controller mixin so the slug/save logic is duplicated on new/edit controllers meaning we need to add a reference manually rather than relying on dependency injection - remove titleObserver checks for non-existent titleObserver
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jun 13, 2017
refs TryGhost/Ghost#8551 - renames editor-base-controller.generateSlug to generateSlugFromTitle - moves `updateSlug` logic from PSM to editor base controller - moves editor base controller save logic into a `save` task - adds `updateSlug` and `save` into a `saveTasks` task group so that calls are queued rather than running concurrently - sets the editor controller on the PSM when accessing the new/edit routes - we use a base controller mixin so the slug/save logic is duplicated on new/edit controllers meaning we need to add a reference manually rather than relying on dependency injection - remove titleObserver checks for non-existent titleObserver
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Jun 13, 2017
closes TryGhost/Ghost#8551 - move `updateSlug` logic from `gh-post-settings-menu` component to `editor-base-controller` mixin - put `updateSlug` and `save` into a task group so that concurrent calls are queued - means that pressing Cmd-S with the cursor still in the slug field will first trigger the `updateSlug` call (triggered by the field blur) then trigger the `save` call (triggered by Cmd-S) when `updateSlug` has finished so there are no conflicts and you still see the "saved" notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue Summary
When editing a post slug in PSM, saving with CMD+S whist the cursor is still in the slug field throws an error:
Attempted to handle event 'becameError' on <post:id> while in state root.loaded.saved
Steps to Reproduce
Two save requests will be triggered, the first will be successful and have the old slug, the second will have the new slug but will fail with an internal server error with the message
Saving failed! Someone else is editing this post.
There are a two issues here:
Technical details:
The text was updated successfully, but these errors were encountered: