This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Safari doesn't show dragged-over state for file uploads #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #7310 - Removes double dashes from modifier classes as safari won’t allow this.
This was referenced Sep 23, 2016
|
@KennethAshley thanks for this! TIL 😁 Never knew Safari ignored classes prefixed with |
kevinansfield
pushed a commit
to kevinansfield/Ghost-Admin
that referenced
this pull request
Sep 24, 2016
closes TryGhost/Ghost#7310 - Removes double dashes from modifier classes as safari won’t allow this.
ErisDS
pushed a commit
that referenced
this pull request
Sep 29, 2016
closes TryGhost/Ghost#7310 - Removes double dashes from modifier classes as safari won’t allow this.
yo1dog
pushed a commit
to yo1dog/Ghost-Admin
that referenced
this pull request
Oct 13, 2016
TryGhost#289) closes TryGhost/Ghost#7310 - Removes double dashes from modifier classes as safari won’t allow this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In reference to #7310
This is not an Ember issue. Safari ignores classes that begin with
--. I believe that none of the IEs allow these types of classes as well.Example:
Sources:
What Changed?
Globally searched for modifier classes that start with
--and removed the first dash.Example
closes #7310
this.