Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

🎨 fix settings menu delete button styles #651

Merged

Conversation

kevinansfield
Copy link
Collaborator

closes TryGhost/Ghost#8345

  • renames .tag-delete-button to .settings-menu-delete-button to match it's more generic purpose
  • match styles as close to 0.11.x as possible, it was necessary to add both stroke and fill to the trashcan SVG for it not to be washed out

screen shot 2017-04-18 at 11 20 37

screen shot 2017-04-18 at 11 21 07

0.11.x style for reference:
screen shot 2017-04-17 at 18 17 44

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 73.62% when pulling 327ef01 on kevinansfield:fix-settings-menu-delete-button-styles into 08edc26 on TryGhost:master.

closes TryGhost/Ghost#8345
- renames `.tag-delete-button` to `.settings-menu-delete-button` to match it's more generic purpose
- match styles as close to 0.11.x as possible, it was necessary to add both stroke and fill to the trashcan SVG for it not to be washed out
@kevinansfield kevinansfield force-pushed the fix-settings-menu-delete-button-styles branch from 327ef01 to 05fb835 Compare April 19, 2017 09:51
@kirrg001 kirrg001 self-assigned this Apr 19, 2017
Copy link
Contributor

@kirrg001 kirrg001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in the standard browsers...FF safari, chrome 👍

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 73.62% when pulling 05fb835 on kevinansfield:fix-settings-menu-delete-button-styles into 6e573b7 on TryGhost:master.

@kirrg001 kirrg001 merged commit ae1b5ee into TryGhost:master Apr 19, 2017
@kevinansfield kevinansfield deleted the fix-settings-menu-delete-button-styles branch June 4, 2018 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag delete button has broken styles
3 participants