Sitemaps correctly filter draft posts

fixes #4612 - adds missing line of code to remove draft posts - adds tests to check drafts aren't added
TryGhost · Dec 9, 2014 · 2ef77d6 · 2ef77d6
1 parent 93c5ff3
commit 2ef77d6
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 0 deletions.
diff --git a/core/server/data/sitemap/manager.js b/core/server/data/sitemap/manager.js
@@ -118,6 +118,10 @@ _.extend(SiteMapManager.prototype, {
             return;
         }
 
+        if (post.get('status') !== 'published') {
+            return;
+        }
+
         this.posts.addUrl(post.toJSON());
     },
 

diff --git a/core/test/integration/sitemap_spec.js b/core/test/integration/sitemap_spec.js
@@ -157,6 +157,25 @@ describe('Sitemap', function () {
             }).catch(done);
         });
 
+        it('doesn\'t add draft pages', function (done) {
+            var manager = makeStubManager(),
+                fake = {
+                    toJSON: sandbox.stub().returns({
+                        status: 'draft'
+                    }),
+                    get: sandbox.stub().returns('draft'),
+                    updated: sandbox.stub().returns('draft')
+                };
+
+            manager.init().then(function () {
+                manager.pageAdded(fake);
+
+                manager.pages.addUrl.called.should.equal(false);
+
+                done();
+            }).catch(done);
+        });
+
         it('deletes pages that were unpublished', function (done) {
             var manager = makeStubManager(),
                 fake = {
@@ -225,6 +244,24 @@ describe('Sitemap', function () {
             }).catch(done);
         });
 
+        it('doesn\'t add draft posts', function (done) {
+            var manager = makeStubManager(),
+                fake = {
+                    toJSON: sandbox.stub().returns({
+                        status: 'draft'
+                    }),
+                    get: sandbox.stub().returns('draft'),
+                    updated: sandbox.stub().returns('draft')
+                };
+
+            manager.init().then(function () {
+                manager.postAdded(fake);
+                manager.posts.addUrl.called.should.equal(false);
+
+                done();
+            }).catch(done);
+        });
+
         it('deletes posts that were unpublished', function (done) {
             var manager = makeStubManager(),
                 fake = {