Enable Escape key to close tag suggestion popup

closes #1893 - Checking the contents of search term after evaluating the keycode caused the suggestion box to be hidden and immediately reshown - Moving the if/else to the top of the function enables us to fix the issue without complicating the suggestion update logic
TryGhost · Jan 14, 2014 · 4dbf57f · 4dbf57f
1 parent c82d2ea
commit 4dbf57f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/core/client/views/editor-tag-widget.js b/core/client/views/editor-tag-widget.js
@@ -134,6 +134,12 @@
             var $target = $(e.currentTarget),
                 searchTerm = $.trim($target.val());
 
+            if (searchTerm) {
+                this.showSuggestions($target, searchTerm);
+            } else {
+                this.$suggestions.hide();
+            }
+
             if (e.keyCode === this.keys.UP) {
                 e.preventDefault();
                 if (this.$suggestions.is(":visible")) {
@@ -159,12 +165,6 @@
             if (e.keyCode === this.keys.UP || e.keyCode === this.keys.DOWN) {
                 return false;
             }
-
-            if (searchTerm) {
-                this.showSuggestions($target, searchTerm);
-            } else {
-                this.$suggestions.hide();
-            }
         },
 
         handleKeydown: function (e) {