Move tests from core to root (#11700)

- move all test files from core/test to test/
- updated all imports and other references
- all code inside of core/ is then application code
- tests are correctly at the root level
- consistent with other repos/projects

Co-authored-by: Kevin Ansfield <kevin@lookingsideways.co.uk>

.gitignore

@@ -76,7 +76,7 @@ b-cov
 *.out
 *.gz
 
-!core/test/utils/fixtures/**/*.csv
+!test/utils/fixtures/**/*.csv
 
 results
 
@@ -114,8 +114,8 @@ projectFilesBackup
 CHANGELOG.md
 
 # Test generated files
-/core/test/functional/*.png
-/core/test/coverage
+test/functional/*.png
+test/coverage
 
 # ignore all custom json files for config
 /config.*.json

.npmignore

@@ -35,7 +35,7 @@ core/built/**/*.map
 core/built/**/test-*
 core/built/**/tests-*
 core/client/**
-core/test/**
+test/**
 CONTRIBUTING.md
 content/themes/casper/SECURITY.md
 SECURITY.md

Gruntfile.js

@@ -123,20 +123,20 @@ const configureGrunt = function (grunt) {
 
             unit: {
                 src: [
-                    'core/test/unit/**/*_spec.js'
+                    'test/unit/**/*_spec.js'
                 ]
             },
 
             acceptance: {
                 src: [
-                    'core/test/api-acceptance/**/*_spec.js',
-                    'core/test/frontend-acceptance/**/*_spec.js'
+                    'test/api-acceptance/**/*_spec.js',
+                    'test/frontend-acceptance/**/*_spec.js'
                 ]
             },
 
             regression: {
                 src: [
-                    'core/test/regression/**/*_spec.js'
+                    'test/regression/**/*_spec.js'
                 ]
             },
 
@@ -383,17 +383,17 @@ const configureGrunt = function (grunt) {
     //
     // `grunt test:unit/apps_spec.js` will run just the tests inside the apps_spec.js file
     //
-    // It works for any path relative to the core/test folder. It will also run all the tests in a single directory
-    // You can also run a test with grunt test:core/test/unit/... to get bash autocompletion
+    // It works for any path relative to the /test/ folder. It will also run all the tests in a single directory
+    // You can also run a test with grunt test:test/unit/... to get bash autocompletion
     //
     // `grunt test:regression/api` - runs the api regression tests
-    grunt.registerTask('test', 'Run a particular spec file from the core/test directory e.g. `grunt test:unit/apps_spec.js`', function (test) {
+    grunt.registerTask('test', 'Run a particular spec file from the /test/ directory e.g. `grunt test:unit/apps_spec.js`', function (test) {
         if (!test) {
             grunt.fail.fatal('No test provided. `grunt test` expects a filename. e.g.: `grunt test:unit/apps_spec.js`. Did you mean `npm test` or `grunt validate`?');
         }
 
-        if (!test.match(/core\/test/) && !test.match(/core\/server/)) {
-            test = 'core/test/' + test;
+        if (!test.match(/test\//) && !test.match(/core\/server/)) {
+            test = 'test/' + test;
         }
 
         // CASE: execute folder

package.json

@@ -29,7 +29,7 @@
     "setup": "yarn install && knex-migrator init && grunt symlink && grunt init || true",
     "lint:server": "eslint --ignore-path .eslintignore 'core/server/**/*.js' 'core/*.js' '*.js'",
     "lint:frontend": "eslint --ignore-path .eslintignore 'core/frontend/**/*.js'",
-    "lint:test": "eslint -c core/test/.eslintrc.json --ignore-path core/test/.eslintignore 'core/test/**/*.js'",
+    "lint:test": "eslint -c test/.eslintrc.json --ignore-path test/.eslintignore 'test/**/*.js'",
     "lint": "yarn lint:server && yarn lint:frontend && yarn lint:test",
     "posttest": "yarn lint",
     "fixmodulenotdefined": "yarn cache clean && cd core/client && rm -rf node_modules tmp dist && yarn && cd ../../"

renovate.json

@@ -15,7 +15,7 @@
       "validator",
       "simple-dom"
     ],
-  "ignorePaths": ["core/test"],
+  "ignorePaths": ["test"],
   "packageRules": [
     {
       "packagePatterns": [ "metascraper" ],

test/.eslintignore

@@ -0,0 +1 @@
+test/coverage/**

core/test/api-acceptance/admin/actions_spec.js → test/api-acceptance/admin/actions_spec.js

@@ -3,7 +3,7 @@ const Promise = require('bluebird');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const ghost = testUtils.startGhost;
 
 let request;

core/test/api-acceptance/admin/config_spec.js → test/api-acceptance/admin/config_spec.js

@@ -2,7 +2,7 @@ const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const ghost = testUtils.startGhost;
 
 let request;

core/test/api-acceptance/admin/db_spec.js → test/api-acceptance/admin/db_spec.js

@@ -2,8 +2,8 @@ const path = require('path');
 const should = require('should');
 const supertest = require('supertest');
 const sinon = require('sinon');
-const config = require('../../../server/config');
-const common = require('../../../server/lib/common');
+const config = require('../../../core/server/config');
+const common = require('../../../core/server/lib/common');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
 

core/test/api-acceptance/admin/email_preview_spec.js → test/api-acceptance/admin/email_preview_spec.js

@@ -3,7 +3,7 @@ const supertest = require('supertest');
 const ObjectId = require('bson-objectid');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 
 const ghost = testUtils.startGhost;
 

core/test/api-acceptance/admin/emails_spec.js → test/api-acceptance/admin/emails_spec.js

@@ -1,7 +1,7 @@
 const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/images_spec.js → test/api-acceptance/admin/images_spec.js

@@ -4,7 +4,7 @@ const should = require('should');
 const supertest = require('supertest');
 const localUtils = require('./utils');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 
 const ghost = testUtils.startGhost;
 

core/test/api-acceptance/admin/integrations_spec.js → test/api-acceptance/admin/integrations_spec.js

@@ -1,7 +1,7 @@
 const _ = require('lodash');
 const should = require('should');
 const supertest = require('supertest');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
 

core/test/api-acceptance/admin/invites_spec.js → test/api-acceptance/admin/invites_spec.js

@@ -2,8 +2,8 @@ const should = require('should');
 const supertest = require('supertest');
 const sinon = require('sinon');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
-const mailService = require('../../../server/services/mail');
+const config = require('../../../core/server/config');
+const mailService = require('../../../core/server/services/mail');
 const localUtils = require('./utils');
 const ghost = testUtils.startGhost;
 

core/test/api-acceptance/admin/key_authentication_spec.js → test/api-acceptance/admin/key_authentication_spec.js

@@ -2,7 +2,7 @@ const should = require('should');
 const supertest = require('supertest');
 const _ = require('lodash');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/mail_spec.js → test/api-acceptance/admin/mail_spec.js

@@ -2,8 +2,8 @@ const should = require('should');
 const supertest = require('supertest');
 const sinon = require('sinon');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
-const mailService = require('../../../server/services/mail');
+const config = require('../../../core/server/config');
+const mailService = require('../../../core/server/services/mail');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/notifications_spec.js → test/api-acceptance/admin/notifications_spec.js

@@ -1,7 +1,7 @@
 const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/oembed_spec.js → test/api-acceptance/admin/oembed_spec.js

@@ -2,7 +2,7 @@ const nock = require('nock');
 const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils/index');
-const config = require('../../../server/config/index');
+const config = require('../../../core/server/config/index');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/pages_spec.js → test/api-acceptance/admin/pages_spec.js

@@ -2,8 +2,8 @@ const should = require('should');
 const supertest = require('supertest');
 const _ = require('lodash');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
-const models = require('../../../server/models');
+const config = require('../../../core/server/config');
+const models = require('../../../core/server/models');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/posts_spec.js → test/api-acceptance/admin/posts_spec.js

@@ -4,8 +4,8 @@ const _ = require('lodash');
 const ObjectId = require('bson-objectid');
 const moment = require('moment-timezone');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
-const models = require('../../../server/models');
+const config = require('../../../core/server/config');
+const models = require('../../../core/server/models');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/roles_spec.js → test/api-acceptance/admin/roles_spec.js

@@ -1,6 +1,6 @@
 const should = require('should');
 const supertest = require('supertest');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
 

core/test/api-acceptance/admin/settings_spec.js → test/api-acceptance/admin/settings_spec.js

@@ -3,7 +3,7 @@ const _ = require('lodash');
 const supertest = require('supertest');
 const os = require('os');
 const fs = require('fs-extra');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/slugs_spec.js → test/api-acceptance/admin/slugs_spec.js

@@ -1,7 +1,7 @@
 var should = require('should'),
     supertest = require('supertest'),
     testUtils = require('../../utils'),
-    config = require('../../../server/config'),
+    config = require('../../../core/server/config'),
     localUtils = require('./utils'),
 
     ghost = testUtils.startGhost,

core/test/api-acceptance/admin/tags_spec.js → test/api-acceptance/admin/tags_spec.js

@@ -1,7 +1,7 @@
 const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/themes_spec.js → test/api-acceptance/admin/themes_spec.js

@@ -4,7 +4,7 @@ const fs = require('fs');
 const _ = require('lodash');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/users_spec.js → test/api-acceptance/admin/users_spec.js

@@ -3,9 +3,9 @@ const _ = require('lodash');
 const supertest = require('supertest');
 const Promise = require('bluebird');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
-const db = require('../../../server/data/db');
-const models = require('../../../server/models');
+const config = require('../../../core/server/config');
+const db = require('../../../core/server/data/db');
+const models = require('../../../core/server/models');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/admin/utils.js → test/api-acceptance/admin/utils.js

@@ -1,7 +1,7 @@
 const url = require('url');
 const _ = require('lodash');
 const testUtils = require('../../utils');
-const schema = require('../../../server/data/schema').tables;
+const schema = require('../../../core/server/data/schema').tables;
 const API_URL = '/ghost/api/canary/admin/';
 
 const expectedProperties = {

core/test/api-acceptance/admin/webhooks_spec.js → test/api-acceptance/admin/webhooks_spec.js

@@ -1,7 +1,7 @@
 const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/content/authors_spec.js → test/api-acceptance/content/authors_spec.js

@@ -3,8 +3,8 @@ const supertest = require('supertest');
 const _ = require('lodash');
 const url = require('url');
 const configUtils = require('../../utils/configUtils');
-const config = require('../../../server/config');
-const models = require('../../../server/models');
+const config = require('../../../core/server/config');
+const models = require('../../../core/server/models');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
 

core/test/api-acceptance/content/key_authentication_spec.js → test/api-acceptance/content/key_authentication_spec.js

@@ -3,7 +3,7 @@ const supertest = require('supertest');
 const _ = require('lodash');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 
 const ghost = testUtils.startGhost;
 

core/test/api-acceptance/content/pages_spec.js → test/api-acceptance/content/pages_spec.js

@@ -3,7 +3,7 @@ const should = require('should');
 const supertest = require('supertest');
 const testUtils = require('../../utils');
 const configUtils = require('../../utils/configUtils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/content/posts_spec.js → test/api-acceptance/content/posts_spec.js

@@ -6,7 +6,7 @@ const cheerio = require('cheerio');
 const moment = require('moment');
 const testUtils = require('../../utils');
 const configUtils = require('../../utils/configUtils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 const ghost = testUtils.startGhost;

core/test/api-acceptance/content/settings_spec.js → test/api-acceptance/content/settings_spec.js

@@ -2,12 +2,12 @@ const should = require('should');
 const supertest = require('supertest');
 const _ = require('lodash');
 const testUtils = require('../../utils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const localUtils = require('./utils');
 
 // Values to test against
-const publicSettings = require('../../../server/services/settings/public');
-const defaultSettings = require('../../../server/data/schema').defaultSettings.blog;
+const publicSettings = require('../../../core/server/services/settings/public');
+const defaultSettings = require('../../../core/server/data/schema').defaultSettings.blog;
 
 const ghost = testUtils.startGhost;
 let request;

core/test/api-acceptance/content/tags_spec.js → test/api-acceptance/content/tags_spec.js

@@ -3,7 +3,7 @@ const supertest = require('supertest');
 const _ = require('lodash');
 const url = require('url');
 const configUtils = require('../../utils/configUtils');
-const config = require('../../../server/config');
+const config = require('../../../core/server/config');
 const testUtils = require('../../utils');
 const localUtils = require('./utils');
 const ghost = testUtils.startGhost;

core/test/api-acceptance/content/utils.js → test/api-acceptance/content/utils.js

@@ -1,7 +1,7 @@
 const url = require('url');
 const _ = require('lodash');
 const testUtils = require('../../utils');
-const schema = require('../../../server/data/schema').tables;
+const schema = require('../../../core/server/data/schema').tables;
 const API_URL = '/ghost/api/canary/content/';
 
 const expectedProperties = {

core/test/frontend-acceptance/default_routes_spec.js → test/frontend-acceptance/default_routes_spec.js

@@ -13,8 +13,8 @@ var should = require('should'),
     _ = require('lodash'),
     testUtils = require('../utils'),
     configUtils = require('../utils/configUtils'),
-    config = require('../../server/config'),
-    settingsCache = require('../../server/services/settings/cache'),
+    config = require('../../core/server/config'),
+    settingsCache = require('../../core/server/services/settings/cache'),
     origCache = _.cloneDeep(settingsCache),
     ghost = testUtils.startGhost,
     request;