Skip to content

Commit

Permalink
Hardcoded success criteria for running canary job
Browse files Browse the repository at this point in the history
refs TryGhost/DevOps#57

- I'm not sure why but I think the `contains` are doing funky things
  and not allowing the build to run when we expect it to
- switching to a slightly different if-statement should help with that
  • Loading branch information
daniellockyer committed Aug 11, 2023
1 parent f26158b commit fd95eac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ jobs:
]
name: Canary
runs-on: ubuntu-latest
if: ${{ always() && needs.job_get_metadata.outputs.is_canary_branch == 'true' && !(contains(needs.*.result, 'cancelled') || contains(needs.*.result, 'failure') || contains(needs.*.result, 'skipped')) }}
if: always() && needs.job_get_metadata.outputs.is_canary_branch == 'true' && needs.job_required_tests.result == 'success' && needs.job_get_metadata.result == 'success'
steps:
- name: Output needs (for debugging)
run: echo "${{ toJson(needs) }}"
Expand Down

0 comments on commit fd95eac

Please sign in to comment.