-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Fixed meta twitter_image output when using
data: post.{slug}
for …
…routes refs #10082 ``` routes: /news/: data: post.news ``` The twitter_image was not available, because the context is [news, post] and the data is in `data.post`. The context helper was incorrect. I think it is still not fully correct, but only focused on this use case. The meta layer needs a full refactoring.
- Loading branch information
Showing
2 changed files
with
34 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fef0aa4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gargol Urgh sorry this commit message needs to be unified with the other meta fixes. Let me know if you need help
fef0aa4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grouped them up a little in the release notes, let me know if it's understandable enough :)