Dynamic Routing: custom meta title & body_class output for static routes using data key #10082

kirrg001 · 2018-10-29T12:46:46Z

Reported in the forum: https://forum.ghost.org/t/when-using-dynamic-routes-meta-title-and-body-class-are-empty/3765

Custom Meta Title

routes:
   /page1/:
    data: page.SLUG
    template: page

If you use

<head>
    <title>{{meta_title}}</title>
</head>

{{#page}}
{{/page}}

It always outputs the blog meta title and not the custom page meta title.

I see two problems:

the StaticRoutesRouter does not forward the correct context, see. It has to forward the resource type as well (e.g. page) if the data key was provided.
The meta title helper is not aware of the this.page context object -> data.page.

Body Class Helper

{{body_class}}

This helper also needs to respect this.page.

Code suggestion:

page = this.post && this.post.page ? {slug: this.post.slug} : this.page || false;
classes.push('page-' + page.slug);

Workaround

{{#page}}
  {{meta_title}}
{{/page}}

Ghost: master

The text was updated successfully, but these errors were encountered:

godofredoninja · 2018-10-29T17:20:45Z

In the dynamic routes also the following fields are empty

— Meta Data
— Twitter Card
— Facebook Card

For example, I have these data added

But he answers me with this data.

kirrg001 · 2018-10-29T18:49:32Z

@godofredoninja Thanks. It's for sure the same underlying problem 👍 The helpers should respect the page context object.

VeloAddict · 2018-10-30T22:36:41Z

Is there a chance this will be fixed in the next release? :)

naz · 2018-10-30T22:58:27Z

@velobarplus if there's somebody from the community to pick it up and contribute a PR we'd definitely help and merge it asap ;)

cotko · 2018-11-12T10:18:54Z

@kirrg001 I'm wiling to do this, but what's up with the missing resourceType in the StaticRoutesRouter, where shuold that be used?
Also you say that key should be used for that: page if the data key was provided - what about when there is more than one data key:

routes:
    data:
        page:
           resource: posts
           type: read
           slug: page1
        morepages:
           resource: posts
           type: read
           slug: page-more
        tags:
           resource: tags
           type: browse
           limit: all

what should the implementation of StaticRoutesRouter.getResourceType() return in this case?

kirrg001 · 2018-11-12T10:35:16Z

@kirrg001 I'm wiling to do this, but what's up with the missing resourceType in the StaticRoutesRouter, where shuold that be used?

Nice 👍

We have to push the resource type into the context object.

e.g. resource type is "page" => context = [this.routerName, resourceType]

kirrg001 · 2018-11-12T10:39:06Z

Also you say that key should be used for that: page if the data key was provided - what about when there is more than one data key:

If there is more than one data definition, the target url does not represent a single resource. I'd not do anything in this case and don't push the resource type.

cotko · 2018-11-12T12:00:13Z

@kirrg001 ok so if a post is turned into a page, then data.page is present here in the schema meta helper (now that page is pushed into a context).

This in turns calls getPostSchema method, but the page only contains partial data about the post; missing are

tags
authors
primary_author = null // probably because of missing authors?
primary_tag = null // probably because of missing tags?

What to do in this case, should post turned into a page also fetch authors and tags so that full data is present, or should meta data in case of page skip this part ?

kirrg001 · 2018-11-12T12:07:29Z

The static controller should probably auto include tags and authors if the resource is post | page.

But i'd suggest to create separate and small pull requests per problem 👍
Thanks for your help!

refs #10082 - this is a requirement if a static route represents a single resource e.g. `data: page.team` - the page resource will no longer live on it's original static url - instead, it now lives somewhere else - that means the whole site needs to act the same than the original static url - the resource does not contain any relations - we don't forward the correct context (page, post, user?) - we override the `include` property for now - need to wait for more use cases or bug reports for this controller - more changes will follow asap

ErisDS · 2019-01-24T08:31:16Z

All issues tagged with routing have been tagged with later and closed until we prioritise working on the Routing feature again.

marekgregor · 2019-02-20T14:47:57Z

Just for information, workaround is described in detail in https://stackoverflow.com/a/54788950/466677

chrisspiegl · 2019-03-07T22:24:01Z

I've noticed this same issue and in my opinion, this basically makes custom routes useless — at least for what I am trying to do (replacing the home page). Technically it works but it's a pain without the {{body_class}} and other parameters being set properly.

I've tried numerous ideas as a workaround but came up empty-handed each time 🙈.

I'm 🤞 for someone to take point on this and get it in on one of the next releases.

ErisDS · 2019-03-11T21:51:02Z

Re-opening this to handle prioritisation

…routes refs #10082 ``` routes: /news/: data: post.news ``` The twitter_image was not available, because the context is [news, post] and the data is in `data.post`. The context helper was incorrect. I think it is still not fully correct, but only focused on this use case. The meta layer needs a full refactoring.

refs TryGhost#10082 - meta_title output wrong meta title Only solves meta_title outout for this use case: ``` routes: /: data: page.{slug} template: t ```

refs TryGhost#10082 - throwed a 500 because this.page was not handled - v2 differentiates between page and post

refs #10082 - meta_title output wrong meta title Only solves meta_title outout for this use case: ``` routes: /: data: page.{slug} template: t ```

refs #10082 - throwed a 500 because this.page was not handled - v2 differentiates between page and post

kirrg001 · 2019-03-12T14:08:57Z

Some fixes landed in 2.17.0.

kirrg001 · 2019-03-14T09:12:00Z

Further problems I see:

the whole meta layer & helper layer needs to be reviewed & updated to understand page and post
data: page.{slug} does not provide authors,tags by default, which "breaks" the tags helper (empty output)
multiple api versions & routing layer/dynamic routing need to be fully reviewed to work 100% generic. There are still some hard-coded checks inside.

The areas need some love and time.

kirrg001 · 2019-03-20T18:45:17Z


Cannot read property 'slug' of undefined

----------------------------------------

TypeError: Cannot read property 'slug' of undefined
    at getPostSchema (/core/server/data/meta/schema.js:72:31)
    at getSchema (/core/server/data/meta/schema.js:179:20)
    at core/server/data/meta/index.js:101:27```

/resources/:
    permalink: /{slug}/
    template: resources
    filter: tag:-news
    order: featured desc, published_at desc
    data:
      post: page.SLUG

The error is not catched/logged properly. Needs investigation why the error is happening.

refs TryGhost#10082 - When specifying an existing page as an allias for collection, e.g: `data: page.it-is-a-page` it was failing to generate metadata

refs #10082 - When specifying an existing page as an allias for collection, e.g: `data: page.it-is-a-page` it was failing to generate metadata

stale · 2019-08-12T13:28:18Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kirrg001 added bug [triage] something behaving unexpectedly themes server / core Issues relating to the server or core of Ghost help wanted [triage] Ideal issues for contributors to help with affects:routing related to the url service & dynamic routing features labels Oct 29, 2018

kirrg001 changed the title ~~Dynamic Routing: custom meta title for static routes does not work~~ Dynamic Routing: custom meta title for static routes & body_class helper Oct 29, 2018

kirrg001 changed the title ~~Dynamic Routing: custom meta title for static routes & body_class helper~~ Dynamic Routing: custom meta title & body_class output for static routes using data key Oct 29, 2018

This was referenced Nov 12, 2018

Include authors and tags if static resource is post #10148

Merged

Fix issue 10082 #10151

Closed

ErisDS added the later [triage] Things we intend to work but are not immediate priority label Jan 23, 2019

ErisDS closed this as completed Jan 23, 2019

ErisDS removed the later [triage] Things we intend to work but are not immediate priority label Mar 11, 2019

ErisDS reopened this Mar 11, 2019

kirrg001 mentioned this issue Mar 11, 2019

Fix some helper output when using data: page.{slug} in routes #10599

Merged

kirrg001 added a commit to kirrg001/Ghost that referenced this issue Mar 12, 2019

🐛 Fixed {{body_class}} helper when using data: page.{slug} in routes

1b2e7c9

refs TryGhost#10082 - throwed a 500 because this.page was not handled - v2 differentiates between page and post

kirrg001 added a commit that referenced this issue Mar 12, 2019

🐛 Fixed {{meta_title}} output when using data: page.{slug} in routes

555dc2f

refs #10082 - meta_title output wrong meta title Only solves meta_title outout for this use case: ``` routes: /: data: page.{slug} template: t ```

kirrg001 added a commit that referenced this issue Mar 12, 2019

🐛 Fixed {{body_class}} helper when using data: page.{slug} in routes

811ba83

refs #10082 - throwed a 500 because this.page was not handled - v2 differentiates between page and post

kirrg001 mentioned this issue Mar 13, 2019

🐛 Fixed "Cannot read property 'feature_image' of undefined" #10602

Merged

1 task

kirrg001 added affects:api Affects the Ghost API and removed help wanted [triage] Ideal issues for contributors to help with labels Mar 14, 2019

kirrg001 self-assigned this Mar 20, 2019

kirrg001 mentioned this issue Apr 30, 2019

🐛 Fixed 404 in collection index page if using data.slug #10718

Merged

naz added a commit to naz/Ghost that referenced this issue Apr 30, 2019

🐛 Fixed meta schema for 'page' context in dynamic routing

63fa899

refs TryGhost#10082 - When specifying an existing page as an allias for collection, e.g: `data: page.it-is-a-page` it was failing to generate metadata

naz added a commit that referenced this issue Apr 30, 2019

🐛 Fixed meta schema for 'page' context in dynamic routing

27dae40

refs #10082 - When specifying an existing page as an allias for collection, e.g: `data: page.it-is-a-page` it was failing to generate metadata

naz unassigned kirrg001 May 14, 2019

stale bot added the stale [triage] Issues that were closed to to lack of traction label Aug 12, 2019

naz added help wanted [triage] Ideal issues for contributors to help with and removed stale [triage] Issues that were closed to to lack of traction labels Aug 12, 2019

ErisDS added later [triage] Things we intend to work but are not immediate priority and removed help wanted [triage] Ideal issues for contributors to help with labels Aug 21, 2019

ErisDS closed this as completed Aug 21, 2019

vikaspotluri123 mentioned this issue Nov 25, 2019

Title/Meta Description not working if custom Routes.yaml Collection in my custom template #11418

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic Routing: custom meta title & body_class output for static routes using data key #10082

Dynamic Routing: custom meta title & body_class output for static routes using data key #10082

kirrg001 commented Oct 29, 2018 •

edited

Loading

godofredoninja commented Oct 29, 2018

kirrg001 commented Oct 29, 2018

VeloAddict commented Oct 30, 2018

naz commented Oct 30, 2018

cotko commented Nov 12, 2018

kirrg001 commented Nov 12, 2018

kirrg001 commented Nov 12, 2018

cotko commented Nov 12, 2018 •

edited

Loading

kirrg001 commented Nov 12, 2018

ErisDS commented Jan 24, 2019

marekgregor commented Feb 20, 2019

chrisspiegl commented Mar 7, 2019

ErisDS commented Mar 11, 2019

kirrg001 commented Mar 12, 2019

kirrg001 commented Mar 14, 2019 •

edited

Loading

kirrg001 commented Mar 20, 2019 •

edited

Loading

stale bot commented Aug 12, 2019

Dynamic Routing: custom meta title & body_class output for static routes using data key #10082

Dynamic Routing: custom meta title & body_class output for static routes using data key #10082

Comments

kirrg001 commented Oct 29, 2018 • edited Loading

Custom Meta Title

Body Class Helper

Workaround

godofredoninja commented Oct 29, 2018

kirrg001 commented Oct 29, 2018

VeloAddict commented Oct 30, 2018

naz commented Oct 30, 2018

cotko commented Nov 12, 2018

kirrg001 commented Nov 12, 2018

kirrg001 commented Nov 12, 2018

cotko commented Nov 12, 2018 • edited Loading

kirrg001 commented Nov 12, 2018

ErisDS commented Jan 24, 2019

marekgregor commented Feb 20, 2019

chrisspiegl commented Mar 7, 2019

ErisDS commented Mar 11, 2019

kirrg001 commented Mar 12, 2019

kirrg001 commented Mar 14, 2019 • edited Loading

kirrg001 commented Mar 20, 2019 • edited Loading

stale bot commented Aug 12, 2019

kirrg001 commented Oct 29, 2018 •

edited

Loading

cotko commented Nov 12, 2018 •

edited

Loading

kirrg001 commented Mar 14, 2019 •

edited

Loading

kirrg001 commented Mar 20, 2019 •

edited

Loading