Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Ghost-Admin Travis failures #10308

Closed
kevinansfield opened this issue Jan 2, 2019 · 0 comments
Closed

Random Ghost-Admin Travis failures #10308

kevinansfield opened this issue Jan 2, 2019 · 0 comments
Labels
affects:admin Anything relating to Ghost Admin

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Jan 2, 2019

Collecting a list of random failures on Travis so that we can make the test suite more reliable. If you see any random failure on Travis please add it here or bump the number of times seen so that we can prioritise.

As for cleaning these up, if no easy solution presents itself it will probably be a case of making a judgement call as to whether the test needs to exist.

x7 (skipped as of TryGhost/Admin@7d85737)

not ok 1506 Firefox 64.0 - [125 ms] - Integration: Component: gh-psm-tags-input updateTags destroys new tag records when not selected
    ---
        message: >
            '#ember-basic-dropdown-content-ember17494 Add "New"...' is not a valid selector
not ok 373 Chrome 71.0 - [93 ms] - Integration: Component: gh-psm-tags-input updateTags destroys new tag records when not selected
    ---
        message: >
            Failed to execute 'querySelectorAll' on 'Document': '#ember-basic-dropdown-content-ember17647 Add "New"...' is not a valid selector.
        stack: >
            Error: Failed to execute 'querySelectorAll' on 'Document': '#ember-basic-dropdown-content-ember17647 Add "New"...' is not a valid selector.
                at selectChoose (http://localhost:7357/assets/tests.js:9966:35)

x5 (skipped as of TryGhost/Admin@7d85737)

not ok 1247 Firefox 64.0 - [654 ms] - Acceptance: Content as admin sorts tags filter alphabetically
    ---
        message: >
            options[0] is undefined

x4 (skipped as of TryGhost/Admin@29d8755)

not ok 1499 Firefox 64.0 - [675 ms] - Integration: Component: gh-profile-image throttles gravatar loading as email is changed
    ---
        message: >
            .gravatar-img background still not changed before debounce timeout: expected div#account-image.gravatar-img[style="background-image: url(//www.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0?s=100&d=404); display: block"] to have an attribute 'style' with the value 'display: none', but the value was 'background-image: url(//www.gravatar.com/avatar/55502f40dc8b7c769880b10874abc9d0?s=100&d=404); display: block'

x2 (skipped as of TryGhost/Admin@29d8755)

not ok 939 Chrome 71.0 - [undefined ms] - Unit: Component: gh-notification closes notification when animationend event is triggered
    ---
        message: >
            Uncaught AssertionError: expected false to be true

x2 (skipped as of TryGhost/Admin@29d8755)

not ok 292 Chrome 71.0 - [undefined ms] - Integration: Component: gh-file-uploader displays upload progress
    ---
        message: >
            Uncaught AssertionError: expected 0 to be above 0

x1 (skipped as of TryGhost/Admin@29d8755)

not ok 1529 Firefox 64.0 - [undefined ms] - Integration: Component: gh-task-button appears disabled whilst running
    ---
        message: >
            uncaught exception: AssertionError: ended class: expected button#ember17882.appear-disabled.ember-view not to have class 'appear-disabled' (:0)
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin refactoring/cleanup labels Jan 2, 2019
@ErisDS ErisDS added tests and removed refactoring labels Jan 22, 2019
@kevinansfield kevinansfield changed the title Random Ghost-Admin test failures Random Ghost-Admin Travis failures Jan 31, 2019
kevinansfield added a commit to TryGhost/Admin that referenced this issue Mar 14, 2019
refs TryGhost/Ghost#10308
- switch to using the `waitFor` helper to wait for changes in DOM rather than relying on unreliable timeouts
kevinansfield added a commit to TryGhost/Admin that referenced this issue Mar 18, 2019
refs TryGhost/Ghost#10308
- removed reliance on `run.later` (`setTimeout`) in tests, instead favouring explicit ember-test-helper methods which wait for DOM changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

No branches or pull requests

2 participants