Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ember deprecation warnings #10310

Closed
2 of 4 tasks
kevinansfield opened this issue Jan 2, 2019 · 3 comments
Closed
2 of 4 tasks

Fix Ember deprecation warnings #10310

kevinansfield opened this issue Jan 2, 2019 · 3 comments
Labels
affects:admin Anything relating to Ghost Admin stale [triage] Issues that were closed to to lack of traction

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Jan 2, 2019 •
edited

Since upgrading Ember in TryGhost/Admin#1044 we have quite a few deprecation warnings. These need to be resolved before the next major Ember version bump.

TODO:
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin refactoring/cleanup labels Jan 2, 2019
@kevinansfield kevinansfield mentioned this issue Jan 8, 2019
Merged
kevinansfield added a commit to TryGhost/Admin that referenced this issue Jan 8, 2019
@kevinansfield
Bump dependencies (#1092)
ffbfb06 
refs TryGhost/Ghost#10310
- bump liquid-fire (cleans up multiple deprecations)
- bump ember-sinon
- bump ember-optional-features
- bump ember-assign-helper
- bump ember-cli-dependency-checker
- bump ember-cli-mirage
- bump ember-cli-pretender
- bump ember-cli-es6-transform

Partial dependency bump. Keeping groups smaller so that any issues are easier to pin down if needed.
kevinansfield added a commit to TryGhost/Admin that referenced this issue Jan 30, 2019
@kevinansfield
Fixed Ember.copy deprecations
18dd5e3 
refs TryGhost/Ghost#10310
- https://emberjs.com/deprecations/v3.x/#toc_ember-runtime-deprecate-copy-copyable
kevinansfield added a commit to TryGhost/Admin that referenced this issue Mar 5, 2019
@kevinansfield
Resolved "Use defineProperty to define computed properties" deprecations
2a505f0 
refs TryGhost/Ghost#10310
- https://www.emberjs.com/deprecations/v3.x/#toc_ember-meta-descriptor-on-object
- required to allow upgrading to Ember > 3.5
@kevinansfield
Copy link
Contributor Author

All deprecations are now resolved other than those raised by use of sendAction in ember-light-table.

@kevinansfield
Copy link
Contributor Author

Since upgrading to Ember 3.8.0 we now have deprecations being raised from ember-route-action-helper which are unlikely to be fixed. Using route actions in this fashion is an anti-pattern so we should try to refactor away from it and remove the addon.

@stale
Copy link

stale bot commented Jun 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Jun 5, 2019
@stale stale bot closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinansfield @ErisDS