Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsplash doesn't show any images before searching #10455

Closed
kevinansfield opened this issue Feb 5, 2019 · 2 comments
Closed

Unsplash doesn't show any images before searching #10455

kevinansfield opened this issue Feb 5, 2019 · 2 comments
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Contributor

Issue Summary

When first opening the Unsplash image selection via the (+) button or /-menu shortcut the image list is empty but it should show Unsplash's "most-recent" list. After searching and removing the text then the most-recent list is shown.

To Reproduce

  1. Refresh the admin and open the editor
  2. Click the (+) button on a blank paragraph and select the Unsplash embed
  3. Note that the Unsplash loads but has an empty image list
  4. Type something in the search box then remove the text
  5. Note that the most-recent list is now displayed correctly

Technical details:

  • Ghost Version: 2.13.2
  • Browser/OS: Chrome / macOS
@kevinansfield kevinansfield added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor affects:admin Anything relating to Ghost Admin labels Feb 5, 2019
@lunaticmonk
Copy link
Contributor

@kevinansfield I got this solved. If you don't mind, may I open a PR for this?

@kevinansfield
Copy link
Contributor Author

@lunaticmonk please do 😄

@lunaticmonk lunaticmonk mentioned this issue Feb 6, 2019
Merged
3 tasks
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Feb 6, 2019
@lunaticmonk @kevinansfield
🐛 Fixed Unsplash image selector being empty when first opening (#1100)
1cf7e57 
closes TryGhost/Ghost#10455
- call `loadNew()` when initialising the `unsplash` service. Services are lazy-initialised so this is only called when the service is first injected which happens when the `<GhUnsplash>` component is first rendered
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinansfield @lunaticmonk