Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Ghost-SDK helpers #10618

Closed
10 of 12 tasks
rishabhgrg opened this issue Mar 18, 2019 · 3 comments
Closed
10 of 12 tasks

Switch to Ghost-SDK helpers #10618

rishabhgrg opened this issue Mar 18, 2019 · 3 comments
Assignees
@rishabhgrg
Labels
server / core Issues relating to the server or core of Ghost

Comments

@rishabhgrg
Copy link
Contributor

rishabhgrg commented Mar 18, 2019 •
edited

We have started to add and maintain collection of tools/helpers to interact with Ghost APIs in [Ghost-SDK], and in line with goal to streamline Ghost Core to be more headless/APIs, aim here is to update Core with existing helpers in SDK along with extracting more helpers/lib to SDK that don't belong in core

This issue collects list of existing and possible new helpers in SDK to update existing code in Ghost core:
@rishabhgrg rishabhgrg self-assigned this Mar 18, 2019
@kirrg001 kirrg001 added the server / core Issues relating to the server or core of Ghost label Mar 18, 2019
@ErisDS
Copy link
Member

ErisDS commented Mar 28, 2019

countWords should also be cleaned up - it's used in Ghost, Ghost-Admin and Ghost-SDK as part of the reading time helper.

rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Apr 15, 2019
@rishabhgrg
Updated to use count words/images helper from SDK
7422c3b 
refs TryGhost/Ghost#10618

- Updated use of `countWords`, `countImages` and `stripTags` helper from Ghost SDK
- Removed existing local utils copy
@rishabhgrg rishabhgrg mentioned this issue Apr 15, 2019
Merged
@rishabhgrg rishabhgrg mentioned this issue Apr 15, 2019
Merged
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Apr 15, 2019
@rishabhgrg
Updated to use count words/images helper from SDK
b262b0f 
refs TryGhost/Ghost#10618

- Updated use of `countWords`, `countImages` and `stripTags` helper from Ghost SDK
- Removed existing local utils copy
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Apr 15, 2019
@rishabhgrg
Updated to use count words/images helpers from SDK
5d28ad3 
refs TryGhost#10618

- Added @tryghost/helpers dependency to use Ghost-SDK helpers
- Updated countWords, countImages helpers and removed local copy
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Apr 15, 2019
@rishabhgrg
Updated to use count words/images helper from SDK
1b4618c 
refs TryGhost/Ghost#10618

- Updated use of `countWords`, `countImages` and `stripTags` helper from Ghost SDK
- Removed existing local utils copy
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Apr 15, 2019
@rishabhgrg
Updated to use count words/images helper from SDK
e754f8c 
refs TryGhost/Ghost#10618

- Updated use of `countWords`, `countImages` and `stripTags` helper from Ghost SDK
- Removed existing local utils copy
rishabhgrg added a commit that referenced this issue Apr 16, 2019
@rishabhgrg
Updated to use count words/images helpers from SDK (#10686)
62f5bda 
refs #10618

- Added @tryghost/helpers dependency to use Ghost-SDK helpers
- Updated countWords, countImages helpers and removed local copy
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Apr 16, 2019
@rishabhgrg
Updated to use count words/images helper from SDK
f15e907 
refs TryGhost/Ghost#10618

- Updated use of `countWords`, `countImages` and `stripTags` helper from Ghost SDK
- Removed existing local utils copy
rishabhgrg added a commit to TryGhost/Admin that referenced this issue Apr 16, 2019
@rishabhgrg
Updated to use count words/images helper from SDK (#1159)
2604e86 
refs TryGhost/Ghost#10618

- Updated use of `countWords`, `countImages` and `stripTags` helper from Ghost SDK
- Removed existing local utils copy
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue May 7, 2019
@rishabhgrg
Updated reading time helper to use SDK
0e7cf44 
refs TryGhost#10618

- Removed duplicate calculation for reading time by using SDK method
@rishabhgrg rishabhgrg mentioned this issue May 7, 2019
Merged
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue May 7, 2019
@rishabhgrg
Updated to use slugify method from SDK for safe string
93f7c77 
refs TryGhost#10618

- Updated lib safe string security method
rishabhgrg added a commit that referenced this issue May 7, 2019
@rishabhgrg
Updated reading time helper to use SDK
65ee0f9 
refs #10618

- Removed duplicate calculation for reading time by using SDK method
rishabhgrg added a commit that referenced this issue May 7, 2019
@rishabhgrg
Updated to use slugify method from SDK for safe string
a4f4a00 
refs #10618

- Updated lib safe string security method
@naz naz mentioned this issue Jun 4, 2019
Closed
6 tasks
naz added a commit to TryGhost/SDK that referenced this issue Jun 6, 2019
@naz
✨ Added social-urls package (#115)
fafb3cb 
refs TryGhost/Ghost#10618

- Extracted from ghost core to decouple lib/common usages between API and dynamic frontend
naz added a commit to naz/Ghost that referenced this issue Jun 6, 2019
@naz
Migrated to use @tryghost/social-urls package
f5544e7 
refs TryGhost#10618

- /lib/social/urls was extracted into SDK to move more modules out of the core and reduce coupling of the theme layer
@rishabhgrg rishabhgrg mentioned this issue Jun 7, 2019
Merged
rishabhgrg added a commit to rishabhgrg/Ghost that referenced this issue Jun 7, 2019
@rishabhgrg
Moved visibility utility from static model fn to Ghost-SDK
f6e3bf3 
refs TryGhost#10618

- Visibility methods don't belong on model, but are generic utils
- Used directly from ghost helper's visibility methods, cleans up core
- Removes direct model dependency of theme helper
- Updated `foreach_spec` to correct test data as per schema - visibility property cannot be empty
rishabhgrg added a commit that referenced this issue Jun 9, 2019
@rishabhgrg
Moved visibility utility from static model fn to Ghost-SDK
a4f119c 
refs #10618

- Visibility methods don't belong on model, but are generic utils
- Used directly from ghost helper's visibility methods, cleans up core
- Removes direct model dependency of theme helper
- Updated `foreach_spec` to correct test data as per schema - visibility property cannot be empty
@naz naz mentioned this issue Jun 18, 2019
Closed
8 tasks
@naz
Copy link
Member

naz commented Jun 26, 2019

@rishabhgrg can you please update the check list on what's done and what's left to close this issue out 😉

@ErisDS ErisDS closed this as completed Aug 21, 2019
@ErisDS
Copy link
Member

ErisDS commented Aug 21, 2019

Closing in favour of having specific tasks when we need them

naz added a commit to naz/Ghost-SDK that referenced this issue Sep 24, 2020
@naz
✨ Added social-urls package (TryGhost#115)
d814c77 
refs TryGhost/Ghost#10618

- Extracted from ghost core to decouple lib/common usages between API and dynamic frontend
naz added a commit to naz/Ghost-SDK that referenced this issue Sep 28, 2020
@naz
✨ Added social-urls package (TryGhost#115)
fe48fa1 
refs TryGhost/Ghost#10618

- Extracted from ghost core to decouple lib/common usages between API and dynamic frontend
naz added a commit to naz/Ghost-SDK that referenced this issue Sep 28, 2020
@naz
✨ Added social-urls package (TryGhost#115)
5623e16 
refs TryGhost/Ghost#10618

- Extracted from ghost core to decouple lib/common usages between API and dynamic frontend
daniellockyer pushed a commit that referenced this issue Jul 26, 2022
@rishabhgrg
Updated to use slugify method from SDK for safe string
58084ac 
refs #10618

- Updated lib safe string security method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabhgrg rishabhgrg

Labels
server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ErisDS @naz @kirrg001 @rishabhgrg