Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default frontend 404 page is broken #10899

Closed
ErisDS opened this issue Jul 12, 2019 · 1 comment
Closed

Default frontend 404 page is broken #10899

ErisDS opened this issue Jul 12, 2019 · 1 comment
Assignees
@peterzimon

Comments

@ErisDS
Copy link
Member

ErisDS commented Jul 12, 2019 •
edited
Loading

Default admin 404 page is pretty:

image

Default frontend 404 page is not:

image

It used to show this lil ghosty thing:

image

To Reproduce

  1. Use a theme that doesn't have a default error page (e.g. Casper 1.4) or remove the error-404.hbs AND error.hbs templates from modern Casper
  2. Try to visit a non existent page on the frontend
  3. See a broken image icon

Not sure if we should be fixing the broken image, or looking to update this template more inline with the new backend 404 cc @peterzimon

Technical details:

  • Ghost Version: master
@peterzimon peterzimon self-assigned this Jul 12, 2019
@peterzimon peterzimon mentioned this issue Jul 15, 2019
Merged
peterzimon added a commit to peterzimon/Ghost that referenced this issue Jul 15, 2019
@peterzimon
Update default 404 page
a482c54 
refs. TryGhost#10899
- removed broken ghost "illustration" from default frontend 404 page
- refined style of 404 page to be more theme agnostic
@peterzimon
Copy link
Contributor

fixed with #10915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterzimon peterzimon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErisDS @peterzimon