Replace page column on posts table with type column

[allouis]

Currently we have a page column which is a non-nullable boolean column which defaults to false

We want to replace this column with a type column,
non-nullable string which defaults to 'post' and has validations to ensure it is obly ever set to 'page' or 'post'

• Remove page column from schema
• Add type column to schema
• Add migration for copying data from page -> type column
• Add migrations for dropping the page column
• Update the model layer to reflect changes
• Update the serialiser layer to reflect changes

[allouis]

@gargol Would be cool if you could give the checkboxes here a once over to confirm it makes sense

[naz]

@allouis the plan looks 👌

Just to expand the topic on serialization level. In v2 I see a pretty straight forward solution modifying the input serializer to fit the new model. Guess the bigger deal will be fitting the new field with v01 controllers 🤔

Also as for model layer changes, it would need a little more details on the approach. Is it going to be something similar to Author model we have where it's a separate model that extends User or the change is purely "cosmetical" in Post model where the flag page will be substituted by appropriate type (this approach seems the most appropriate in terms of time/impact)?

[allouis]

👍

I think both input & output serialiser would need to be changed right? because the v2 api outputs the page parameter when reading from it right?

As for model layer changes - I was thinking that it would just be replacing the page flag - but tbh a new model is a more complete approach - grows the size of this issue a lot though - what do you think?

[naz]

I think both input & output serialiser would need to be changed right?

Yup 👍

but tbh a new model is a more complete approach

Yes, this is true and I don't think it's worth an effort just to be "clean" in respect of model separation. Changing existing post model should be enough.

[allouis]

Awesome - I agree 💃