Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text expansions do not work immediately after a soft-break atom #11020

Closed
kevinansfield opened this issue Aug 14, 2019 · 3 comments
Closed

Text expansions do not work immediately after a soft-break atom #11020

kevinansfield opened this issue Aug 14, 2019 · 3 comments
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly stale [triage] Issues that were closed to to lack of traction

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Aug 14, 2019

Issue Summary

If you use Shift+Enter to create a soft-break atom, then at the beginning of the new line type a markdown expansion, it's not recognised by the text expansions and won't apply formatting when you close the markdown.

To Reproduce

  1. Create a new post in the editor
  2. Type something then press Shift+Enter
  3. Type *testing*
  4. Note that the text does not change to italic when typing the closing *

If you repeat the steps but type a space or anything else before *testing* then the expansion will complete correctly.

The problem likely lies with the text-expansion regexes where it's not recognising the soft-break as a start of a section (^) or as whitespace (\s).

@kevinansfield kevinansfield added bug [triage] something behaving unexpectedly affects:editor Work relating to the Koenig Editor affects:admin Anything relating to Ghost Admin labels Aug 14, 2019
@stale
Copy link

stale bot commented Nov 12, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Nov 12, 2019
@marek-lach
Copy link

What’s the current status for addressing this?

@stale stale bot removed the stale [triage] Issues that were closed to to lack of traction label Nov 12, 2019
@stale
Copy link

stale bot commented Feb 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Feb 10, 2020
@stale stale bot closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin affects:editor Work relating to the Koenig Editor bug [triage] something behaving unexpectedly stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Development

No branches or pull requests

2 participants