Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrations page in dark mode is missing transparent icons. #11342

Closed
aidenmitchell opened this issue Nov 6, 2019 · 4 comments
Closed

Integrations page in dark mode is missing transparent icons. #11342

aidenmitchell opened this issue Nov 6, 2019 · 4 comments
Assignees
@peterzimon
Labels
affects:admin Anything relating to Ghost Admin css / design / mobile Minor UI issues

Comments

@aidenmitchell
Copy link

aidenmitchell commented Nov 6, 2019 •
edited

Issue Summary

Integrations page in dark mode is missing transparent icons.

To Reproduce

  1. Switch to Dark Mode
  2. Go to the Integrations tab

Zapier and AMP icons are not transparent and have a white background.
Similar to #10161

Technical details:

  • Ghost Version: 3.0.2
  • Node Version: Unsure
  • Browser/OS: Safari, MacOS Catalina
  • Database: mysql

Screen Shot 2019-11-05 at 7 16 35 PM
@aidenmitchell
Copy link
Author

Update: Also the More ellipsis icon has a darker shade of black than the rest of the UI.

@naz naz added affects:admin Anything relating to Ghost Admin css css / design / mobile Minor UI issues labels Nov 7, 2019
@umuur
Copy link
Contributor

umuur commented Dec 28, 2019

can I take this?

@aidenmitchell
Copy link
Author

Still hasn't been fixed as of 3.11.0

peterzimon added a commit to TryGhost/Admin that referenced this issue Apr 20, 2020
@peterzimon
Icon fixes on integrations night shift
00b7ec2 
refs. TryGhost/Ghost#11342

- replaced Zapier and Amp logos for SVGs with transparent background so that there's no white background in night shift
- inverted Unsplash icon in night shift (similarly to Mailchimp, Typeform etc.)
- replaced ellipsis icon for SVG and handled night shift color change
- removed unnecessary icon container drop shadow in integration detail pages for night shift
@peterzimon
Copy link
Contributor

Fixed with TryGhost/Admin@00b7ec2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterzimon peterzimon

Labels
affects:admin Anything relating to Ghost Admin css / design / mobile Minor UI issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peterzimon @naz @umuur @aidenmitchell